Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pangolingo created a review comment on a pull request on thoughtbot/fishery
Great solution. To help with future maintenance, I'd love to add a comment here ```suggestion if (Array.isArray(srcVal) || ArrayBuffer.isView(srcVal)) { // don't try to merge arrays or s...
pangolingo created a review on a pull request on thoughtbot/fishery
Thanks for this PR! Could we add a test to prevent future regressions? Here's what I wrote when testing this change: ```typescript // lib/__tests__/merge-params.test.ts it('does not conve...
pangolingo created a review on a pull request on thoughtbot/fishery
Thanks for this PR! Could we add a test to prevent future regressions? Here's what I wrote when testing this change: ```typescript // lib/__tests__/merge-params.test.ts it('does not conve...
pangolingo closed a pull request on thoughtbot/fishery
Automatically Generated: Update Dynamic Section in README
This PR was automatically generated to update the dynamic section in the README file. Whenever the README is updated, this workflow is triggered to dynamically render the snippet used in the README.
pangolingo closed a pull request on thoughtbot/fishery
Automatically Generated: Update Dynamic Section in README
This PR was automatically generated to update the dynamic section in the README file. Whenever the README is updated, this workflow is triggered to dynamically render the snippet used in the README.
pangolingo closed a pull request on thoughtbot/fishery
Automatically Generated: Update Dynamic Section in README
This PR was automatically generated to update the dynamic section in the README file. Whenever the README is updated, this workflow is triggered to dynamically render the snippet used in the README.
pangolingo pushed 6 commits to main thoughtbot/fishery
- Allow specifying the type of params Signed-off-by: Antony Méchin <[email protected]> c1069de
- Prettify Signed-off-by: Antony Méchin <[email protected]> a5465a5
- - Improve test case for explicit Params - Update README.md accordlingly Signed-off-by: Antony Méchin <antony.mechin@... 5231a7b
- Merge remote-tracking branch 'thoughbot/main' into HEAD aa0a973
- Fix minor mindos 0688fa6
- Merge pull request #108 from Dimrok/main Allow specifying the type of params c9e8ab9
pangolingo closed a pull request on thoughtbot/fishery
Allow specifying the type of params
## Rational Like https://github.com/thoughtbot/fishery/pull/94 with `Date`, I faced a problem with some "complex" types I wanted to pass as params. The Pull Request allows one to specify the...
pangolingo created a review on a pull request on thoughtbot/fishery
With the readme update, this is good to go! Once it's merged, I'll work on prepping a minor version release, since there are no breaking changes.
pangolingo opened a pull request on thoughtbot/fishery
Updated CONTRIBUTING.md with info about creating a new GitHub release
This was not documented anywhere - Rakesh and I had to figure it out ourselves. We wanted to document it for next time around.
pangolingo created a branch on thoughtbot/fishery
di-updated-contributing - A library for setting up JavaScript objects as test data
pangolingo pushed 2 commits to main thoughtbot/fishery
pangolingo closed a pull request on thoughtbot/fishery
Upgraded Rollup and its dependencies to the latest versions
This required changing the config's file extension to `.mjs`. I read through the upgrade notes and did not see any other major changes that would fail silently. This builds on another PR: #149
pangolingo created a review comment on a pull request on thoughtbot/fishery
This is auto-added by newer versions of Yarn.
pangolingo created a comment on a pull request on thoughtbot/fishery
Thanks for this improvement! @rakeshpetit and I tried it out and we agree that it makes this type of Class parameter behavior possible without having to hack around TypeScript. We left a few com...
pangolingo created a comment on a pull request on thoughtbot/fishery
Let's add a README update talking about this change too. I think the `### Typechecking ` section would be a good place. > #### Typechecking params that are classes > > By default Fishery us...
pangolingo pushed 1 commit to di-native-validation-explainer pangolingo/react-hook-form-documentation
- Update register.mdx with info about validation rules Explain that `register()`'s validation rules don't apply native... e1e3d30
pangolingo pushed 7 commits to di-native-validation-explainer pangolingo/react-hook-form-documentation
- formstate & useformstate to mdx (#1114) 0671b91
- fix desktop nav 55420fb
- setvalue to mdx (#1116) 93f9d3d
- register to mdx (#1115) * register to mdx * revert tips section a95fb76
- update on new api create form control (#1113) * update on new api create form control * update doc on create form... abc2784
- update doc 4b1b80f
- Merge branch 'react-hook-form:master' into di-native-validation-explainer 1bd9103
pangolingo pushed 6 commits to master pangolingo/react-hook-form-documentation
- formstate & useformstate to mdx (#1114) 0671b91
- fix desktop nav 55420fb
- setvalue to mdx (#1116) 93f9d3d
- register to mdx (#1115) * register to mdx * revert tips section a95fb76
- update on new api create form control (#1113) * update on new api create form control * update doc on create form... abc2784
- update doc 4b1b80f
pangolingo created a branch on pangolingo/react-hook-form-documentation
di-native-validation-explainer - 📋 Official documentation
pangolingo created a comment on an issue on thoughtbot/fishery
I don't know why Typescript requires you to narrow your type (`status: 'published' as const`) for the class extension but not the factory. They're both using the same `define` function internally. ...
pangolingo created a comment on an issue on thoughtbot/fishery
I have observed this behavior too. This is a Typescript bug/feature (I also am not sure which to call it). Here's some details: - [StackOverflow post explaining why Typescript lets this happen](ht...
pangolingo created a comment on an issue on thoughtbot/fishery
This is more of a JavaScript syntax issue than a problem with this library. You're free to use an explicit undefined check in your factory instead of destructuring assignment if that works better f...
pangolingo created a comment on a pull request on thoughtbot/fishery
I compared the built files (files in the `/dist` directory after this upgrade. There are few changes between the output of the new Rollup version vs the old one. They seem mostly syntax improvement...
pangolingo pushed 6 commits to di-rollup-upgrades thoughtbot/fishery
- Merge pull request #149 from thoughtbot/di-jest-ts-upgrades Upgraded Jest and Typescript to newer versions 88ae9ea
- Bump braces from 3.0.2 to 3.0.3 Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changel... 1e074fc
- Merge pull request #152 from thoughtbot/dependabot/npm_and_yarn/braces-3.0.3 Bump braces from 3.0.2 to 3.0.3 da01331
- Bump micromatch from 4.0.4 to 4.0.8 Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.4 to 4.0.8... 80e6388
- Merge pull request #153 from thoughtbot/dependabot/npm_and_yarn/micromatch-4.0.8 Bump micromatch from 4.0.4 to 4.0.8 511d39f
- Upgraded Rollup and its dependencies to the latest versions This required changing the config's file extension to `.... 4167a25
pangolingo closed a pull request on thoughtbot/fishery
Automatically Generated: Update Dynamic Section in README
This PR was automatically generated to update the dynamic section in the README file. Whenever the README is updated, this workflow is triggered to dynamically render the snippet used in the README.