Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

rakeshpetit

rakeshpetit published a release on thoughtbot/fishery
2.2.3
## What's Changed - Security updates and dependency upgrades - Upgraded the build tools ## New Contributors * @sarahraqueld made their first contribution in https://github.com/thoughtbot/fish...
rakeshpetit created a review comment on a pull request on thoughtbot/fishery
It would be good to add this expectation in both the tests where we verify the type of the value in the created object. ``` expect(user.createdAt).toBeInstanceOf(DateTime); ```

View on GitHub

rakeshpetit created a review on a pull request on thoughtbot/fishery

View on GitHub

rakeshpetit created a review comment on a pull request on thoughtbot/fishery
It would be good to add a few more tests demonstrating how `DeepPartial` handles nested values. ``` type Company = { name: string; users: User[]; }; const companyFactory = Factory.def...

View on GitHub

rakeshpetit created a review on a pull request on thoughtbot/fishery

View on GitHub

rakeshpetit created a review on a pull request on thoughtbot/fishery
LGTM! As long as the build passes.

View on GitHub

rakeshpetit created a review comment on a pull request on thoughtbot/fishery
Do we have to mention this? What would happen if we did not add the `packageManager`?

View on GitHub

rakeshpetit created a review on a pull request on thoughtbot/fishery

View on GitHub

rakeshpetit created a review on a pull request on thoughtbot/fishery
LGTM! I checked that the CI shows Node 22 and is passing all the checks.

View on GitHub

rakeshpetit created a review comment on a pull request on thoughtbot/fishery
I've not added this file in repos that use yarn. Is this a new file required for v4?

View on GitHub

rakeshpetit created a review on a pull request on thoughtbot/fishery

View on GitHub

rakeshpetit created a review on a pull request on thoughtbot/fishery
Looks good!

View on GitHub