Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
OlivierNicole created a comment on a pull request on ocsigen/js_of_ocaml
@rickyvetter If you want to run benchmarks on this branch and check that nothing behaves unexpectedly, I expect this to be close to the final version.
OlivierNicole created a review comment on a pull request on ocsigen/js_of_ocaml
No, the behavior is the same, as checked by the tests in `tests-ocaml/lib-effects/`.
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
So we have different behavior between wasm and js ?
OlivierNicole created a review comment on a pull request on ocsigen/js_of_ocaml
In both JS and Wasm, performing under `caml_assume_no_perform` must raise `Effect.Unhandled`, expect after installing a handler, i.e. resuming a stack. On the js_of_ocaml side, it is ensured by hav...
OlivierNicole created a review comment on a pull request on ocsigen/js_of_ocaml
This value is the same as in `caml_callback`. I guess it has been chosen because empirically, it avoids trampolining too often but still avoids overflow. I added a comment saying this.
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
I dont see any equivalent logic on the js side. I seems that caml_assume_no_perform completely forbid effect with wasm while effects could still happen with js after resuming a stack ? I must admit...
OlivierNicole created a review comment on a pull request on ocsigen/js_of_ocaml
Shouldn’t we wait for the new flag to be supported by Dune before documenting it? See https://github.com/ocsigen/js_of_ocaml/pull/1461#issuecomment-2545773411.
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
``` let doc = "Select an implementation of effect handlers. [$(docv)] should be one of $(b,cps) \ or $(b,double-translation). Effects won't be supported if unspecified." ```
OlivierNicole created a review comment on a pull request on ocsigen/js_of_ocaml
never mind, the order of comments is probably mixed in the Github interface.
OlivierNicole created a review comment on a pull request on ocsigen/js_of_ocaml
I’m not sure to understand what needs to be updated.
smorimoto opened an issue on ocsigen/js_of_ocaml
[FEATURE REQUEST] Support multi-line JSDoc comments at runtime
**Is your feature request related to a problem? Please describe.** I wish to have support for a more comprehensive comment format to allow runtime type checking with the TypeScript compiler. ...
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
can we have a comment explaining this ?
vouillon created a review comment on a pull request on ocsigen/js_of_ocaml
I believe this change is no longer relevant and can be reverted.
hhugo created a comment on a pull request on ocsigen/js_of_ocaml
> @hhugo Is there something remaining for this to be merged? Do you consider [ocaml/dune#11222](https://github.com/ocaml/dune/pull/11222) to be a necessary prerequisite? [ocaml/dune#11222](htt...
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
Can you say more about this ? why 10 and not just 1 ?