Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

OlivierNicole

OlivierNicole created a comment on a pull request on ocaml/ocaml
Thanks to @yallop for finding a number of remaining mistakes in `iarray.mli` and `iarray.ml`!

View on GitHub

OlivierNicole created a review comment on a pull request on ocaml/ocaml
Done.

View on GitHub

OlivierNicole created a review on a pull request on ocaml/ocaml

View on GitHub

OlivierNicole created a review comment on a pull request on ocaml/ocaml
No, it doesn’t seem to.

View on GitHub

OlivierNicole created a review on a pull request on ocaml/ocaml

View on GitHub

OlivierNicole pushed 1 commit to immutable-arrays OlivierNicole/ocaml
  • CR: Fix copyright, remove non-existent attribute 078fc40

View on GitHub

OlivierNicole pushed 1 commit to immutable-arrays OlivierNicole/ocaml
  • CR: Fix mistakes in Iarray comments 617ab47

View on GitHub

OlivierNicole created a review comment on a pull request on ocaml/ocaml
Good question. The convention I have followed previously is to have only the original authoring entity, so I would remove the 1996 Inria lines. @Octachron do you agree?

View on GitHub

OlivierNicole created a review on a pull request on ocaml/ocaml

View on GitHub

OlivierNicole created a comment on an issue on ocaml-multicore/multicoretests
> Can we conclude that parallel usage may be type unsafe? Ping [@OlivierNicole](https://github.com/OlivierNicole): WDYT? 🤔 It shouldn’t be, and yet it seems that it is. I guess my next move, if ...

View on GitHub

OlivierNicole created a comment on a pull request on ocaml/ocaml
We could agree on a fixed duration for people to cast a vote on the name, possibly giving arguments. People could change their vote during that period if they want to. And at the end, choose the op...

View on GitHub

OlivierNicole pushed 1 commit to immutable-arrays OlivierNicole/ocaml
  • CR: Move some iarray tests to more relevant path dc80ec3

View on GitHub

OlivierNicole created a comment on a pull request on ocaml/ocaml
To summarize the state of this PR: it is a port of a series of patches made on the Jane Street compiler. The `typing/` and `toplevel/` parts have been reviewed by @gasche and the `lambda/` part by ...

View on GitHub

OlivierNicole pushed 10 commits to immutable-arrays OlivierNicole/ocaml

View on GitHub

OlivierNicole created a comment on a pull request on ocaml/ocaml
> @lthls is (as usual) correct that the string stuff comes from the needs of js_of_ocaml Thanks for reminding me, it had slipped my mind. I removed the dedicated primitives and replaced them ...

View on GitHub

OlivierNicole pushed 10 commits to immutable-arrays OlivierNicole/ocaml

View on GitHub

OlivierNicole pushed 2 commits to immutable-arrays OlivierNicole/ocaml
  • Remove unnecessary iarray primitives Namely %iarray_to_array and %iarray_of_array. a9fc8a3
  • Update changelog f603113

View on GitHub

OlivierNicole pushed 69 commits to immutable-arrays OlivierNicole/ocaml
  • Rewrite mutable globals for GC control to be atomic This rewrites four globals to be atomic, thus avoiding data race... 94fafd4
  • manual: fix name of caml_hash_variant in the C interface The function is called hash_variant in Btype, but caml_hash... fa8cd4d
  • faster caml_continuation_use_and_update_handler_noexc fbe9ced
  • Merge pull request #13701 from hhugo/follow-12735 Faster caml_continuation_use_and_update_handler_noexc 48ecd94
  • Changes d236751
  • Support unicode identifiers in comments 385ab8f
  • typos in ephemeron-related comments e8d4798
  • typemod: labeled argument [strengthen:bool] for type_{module,application} d75d775
  • typemod: labeled argument [funct_body:bool] for type_{module,application,open_decl} 85970ee
  • Add test for unicode identifier in comment ccbd123
  • Merge pull request #13709 from gasche/typemod-readability-tweaks [refactoring] typemod.ml readability tweaks 5e30513
  • Add `Char.Ascii` module (#13695) * char.mli: add a module preamble. * char.mli: replace incorrect mentions of 'AS... 4d2298d
  • [minor] Document locking behaviour of C channels bf7d441
  • Fix deadlock in runtime events 85d15f3
  • Avert potential deadlock in caml_iterate_named_values But have not found uses of caml_iterate_named_values in the wi... 88f1c1c
  • Use caml_plat_lock_non_blocking in signals.c, clarify signal installation 50bf0b0
  • Replace caml_plat_locking with caml_plat_non_blocking in io.c We apply the rule of using the non-blocking version wh... 2ff121a
  • Document remaining uses of caml_plat_lock d931f22
  • Changes a3c0dd0
  • Changes 4c9f1d9
  • and 49 more ...

View on GitHub

OlivierNicole created a comment on a pull request on ocaml/ocaml
> Personally my main question is whether there has been a full review of the implementation (and also: if we need to grow more knowledge within upstream maintainers of how the code works), and it i...

View on GitHub

OlivierNicole created a comment on a pull request on ocsigen/js_of_ocaml
If the calling convention can be chosen dynamically, doesn’t it open the way to being able to link together files compiled with `--effects=cps` and files compiled with `--effects=double-translation`?

View on GitHub

OlivierNicole created a review comment on a pull request on ocsigen/js_of_ocaml
I see, so it goes through escaping.

View on GitHub

OlivierNicole created a review on a pull request on ocsigen/js_of_ocaml

View on GitHub

OlivierNicole created a comment on a pull request on ocsigen/js_of_ocaml
Here’s how this PR affects the (bzip2-ed) code size blowup induced by `--effects=double-translation` compared to `--effects=cps`: | Revision | `master` (3d645b9) | this PR | --------------|-...

View on GitHub

OlivierNicole created a review comment on a pull request on ocsigen/js_of_ocaml
I can’t find where in the code this happens—making sure that all non-exact calls use the CPS calling convention. Would you know?

View on GitHub

OlivierNicole created a review on a pull request on ocsigen/js_of_ocaml
This looks good to me! I only have a question on an unrelated point.

View on GitHub

OlivierNicole created a review on a pull request on ocsigen/js_of_ocaml
This looks good to me! I only have a question on an unrelated point.

View on GitHub

OlivierNicole created a comment on a pull request on ocsigen/js_of_ocaml
I’m looking at this, but I think I need to reflect a bit more to understand this statement: > We don't require escaping functions nor functions called from a CPS call site to have a CPS variant.

View on GitHub

OlivierNicole created a comment on a pull request on ocsigen/js_of_ocaml
IMO a coordination effort is probably not necessary. The blog post is nearly complete, so it should be fine.

View on GitHub

OlivierNicole created a comment on a pull request on ocaml/ocaml
`Parray_of_iarray` and `Parray_to_iarray` have been introduced in https://github.com/ocaml-flambda/ocaml-jst/pull/127, apparently to avoid using `Obj.magic`. We could replace them with a simple `%i...

View on GitHub

OlivierNicole created a comment on a pull request on ocaml/ocaml
> I had a look at the code in `toplevel` and `typing`, which mostly looks reasonable to me. Thank you for this review work! > I wonder whether @lthls (or one of his excellent colleagues) woul...

View on GitHub

Load more