Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
So we have different behavior between wasm and js ?
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
I dont see any equivalent logic on the js side. I seems that caml_assume_no_perform completely forbid effect with wasm while effects could still happen with js after resuming a stack ? I must admit...
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
``` let doc = "Select an implementation of effect handlers. [$(docv)] should be one of $(b,cps) \ or $(b,double-translation). Effects won't be supported if unspecified." ```
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
can we have a comment explaining this ?
hhugo created a comment on a pull request on ocsigen/js_of_ocaml
> @hhugo Is there something remaining for this to be merged? Do you consider [ocaml/dune#11222](https://github.com/ocaml/dune/pull/11222) to be a necessary prerequisite? [ocaml/dune#11222](htt...
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
Can you say more about this ? why 10 and not just 1 ?
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
I don't like that `None` currently mean unsupported for jsoo and jspi for wasmoo
hhugo created a review comment on a pull request on ocsigen/js_of_ocaml
What about doing something similar to `target` above. ```ocaml type effects_backend = | `Cps | `Double_translation | `Jspi | `Not_supported | `None let effects_ : effects_backen...
hhugo created a comment on a pull request on ocsigen/js_of_ocaml
@vouillon, should we merge in the current state or should we wait for the wasm runtime?
hhugo created a comment on a pull request on ocsigen/js_of_ocaml
> @hhugo Is there something remaining for this to be merged? Do you consider [ocaml/dune#11222](https://github.com/ocaml/dune/pull/11222) to be a necessary prerequisite? I'd like to do another r...
hhugo created a review comment on a pull request on ocaml/dune
The downside is that it increases the number of dune rules registered in dune. One rule per lib per config in `Config.all`. We currently have 27 config on master. Having cps, double_translate, jsp...
hhugo created a review comment on a pull request on ocaml/dune
The name `recent` does not say much . I think I would rather pass the version down and compare against it when needed.
hhugo created a comment on a pull request on ocsigen/js_of_ocaml
@vouillon, thanks for the review. I've applied you suggestion and removed the caml_fiber_stack to only keep `caml_current_stack`.