Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mellyeliu created a review comment on a pull request on facebook/stylex
I was going after an assumed path that this would be within node_modules/@stylex/ etc path or regardless be _consistent_ across files but you're right it's not guaranteed to be the project root, up...
mellyeliu created a review comment on a pull request on facebook/stylex
https://nodejs.org/api/fs.html#fs_fs_exists_path_callback `fs.exists` is deprecated and may cause issues with modern node versions
mellyeliu pushed 1 commit to main facebook/stylex
- fix: add cache invalidation on config change (#871) 4c887b7
mellyeliu closed a pull request on facebook/stylex
fix: add cache invalidation on config change
## Context Cherry picking https://github.com/facebook/stylex/pull/862 for version history ## Pre-flight checklist - [ ] I have read the contributing guidelines [Contribution Guideli...
github-actions[bot] created a comment on a pull request on facebook/stylex
<!-- workflow-benchmarks-size-data --> ### workflow: benchmarks/size Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better. > @stylexjs/scripts...
mellyeliu opened a pull request on facebook/stylex
fix: add cache invalidation on config change
## Context Cherry picking https://github.com/facebook/stylex/pull/862 for version history ## Pre-flight checklist - [ ] I have read the contributing guidelines [Contribution Guideli...
mellyeliu pushed 3 commits to feat-relative-cache-path facebook/stylex
mellyeliu pushed 2 commits to feat-relative-cache-path facebook/stylex
mellyeliu created a branch on facebook/stylex
revert-862-cli-cache-config - StyleX is the styling system for ambitious user interfaces.
zaydek created a comment on an issue on facebook/stylex
Closing as https://github.com/facebook/stylex/discussions/870 addresses the problem head on.
zaydek closed an issue on facebook/stylex
Best practices for merging styles: createTheme or stylex.create with [...] syntax?
I found in my [experimentation](https://github.com/facebook/stylex/discussions/849) that I cannnot merge themes in StyleX. This may be intentional behavior but it's not what I was expecting and @ne...
zaydek created a comment on an issue on facebook/stylex
Quick follow up: Using the styles pattern worked. I also read https://github.com/facebook/stylex/blob/6df047c7933c765c7e7de552faa69d569a152fb4/apps/docs/docs/learn/06-recipes/05-merge-themes.mdx an...
zaydek created a comment on an issue on facebook/stylex
Thanks! I think themes are designed for a different use case than I may be imagining. My constraints are I want to be able to theme an app using runtime values where theme tokens cannot necesarrily...
zaydek reopened an issue on facebook/stylex
Unexpected behavior: Themes do not merge, instead last theme wins
I found in my [experimentation](https://github.com/facebook/stylex/discussions/849) that I cannnot merge themes in StyleX. This may be intentional behavior but it's not what I was expecting and @ne...
Jta26 created a comment on a pull request on facebook/stylex
> Can we clarify this with documentation Yeah documentation is probably the best way to disambiguate this.
nmn created a comment on a pull request on facebook/stylex
> This is also kinda awkward, but maybe valueTypes is better. This aligns with the actual name for such things. I don't know if it's worth renaming the existing public APIs such as `stylex.types...
nmn pushed 1 commit to docs/reset-theme-recipe facebook/stylex
- docs: clarify that only themes for the *same* VarGroup are mutually exclusive 6df047c
nmn created a comment on a pull request on facebook/stylex
@necolas Let me take a crack at rewording the recipes so that fact is clearer.
nmn created a comment on a pull request on facebook/stylex
Will merge this PR after doing more testing as this code primarily affects internal code.
Jta26 created a comment on a pull request on facebook/stylex
> Should the types be under stylex.types instead? I think this is a better organization in terms of usage with `stylex.types` functions, however it's kinda confusing when you have `stylex.Static...
necolas created a comment on a pull request on facebook/stylex
A theme is actually just a different set of values for a given bag of vars. So you can merge themes, just not themes for the same vars.
