yujing-student created a review on a pull request on lisagjh/voorhoede

January 23, 2025 2:57pm

Great solution  And on windows xp it is still working ![image](https://github.com/user-attachment...

View on GitHub

yujing-student created a comment on a pull request on lisagjh/voorhoede

January 23, 2025 2:56pm

> @yujing-student > > I added `overflow: hidden` to the `ul` element > > commit: [2c9472a](https://github.com/lisagjh/voorhoede/commit/2c9472a3ff82b0a6a0a0021ad3d8c074905fd5c7) Great solut...

View on GitHub

yujing-student created a review on a pull request on lisagjh/voorhoede

January 23, 2025 2:47pm

In browsrestack on old devices it is working on windows xp.  On mobile it works too on the iphone 5. ...

View on GitHub

yujing-student pushed 1 commit to release-candidate fdnd-agency/voorhoede

January 22, 2025 3:19pm

• Create handover.md 566e77a

View on GitHub

yujing-student pushed 1 commit to main fdnd-agency/voorhoede

January 22, 2025 3:14pm

• Create handover.md 6379c95

View on GitHub

yujing-student closed an issue on fdnd-agency/voorhoede

January 22, 2025 2:44pm

Refactor: deprecated svelte features to Svelte 5

- Refactor this component, slot is deprecated in Svelte5.: https://github.com/lisagjh/voorhoede/blob/efc1ebce47549e9799eac11f76a5b69a716851a5/src/routes/%2Bpage.svelte#L16 - use props() to expor...

yujing-student closed an issue on fdnd-agency/voorhoede

January 22, 2025 2:43pm

Dropdown menu component

Het maken van een dropdown component die op verschillende pagina's te gebruiken is o.a Ledenpagina en vacaturepagina. # Wat er gedaan moet worden - Research naar HTML (Toegankelijkheid en semanti...

yujing-student closed an issue on fdnd-agency/voorhoede

January 22, 2025 2:43pm

Filter section layout

# This issue includes - Een responsive layout maken voor de filters - Testen op responsiveness met bijvoorbeeld Polypane **** # Reference of how it should look ![Image](https://github.com/user-...

yujing-student closed an issue on fdnd-agency/voorhoede

January 22, 2025 2:42pm

Redesign Vacancy Card

# Herontwerpen van vacatures Zelf ben ik ontevreden over het ontwerp wat is opgeleverd, Declan vindt het daarnaast ook veel beter kunnen op veel plekken, hij heeft het bekritiseerd tijdens onze m...

yujing-student deleted a branch fdnd-agency/voorhoede

January 22, 2025 2:41pm

111-searchbar-component-enhance

yujing-student pushed 16 commits to main lisagjh/voorhoede

January 22, 2025 2:39pm

• Fix #230 I removed the double textarea in css Fix https://github.com/fdnd-agency/voorhoede/issues/230 59ac068
• refactor #203 this issue https://github.com/fdnd-agency/voorhoede/issues/202 f915c90
• Build: I added the css on the form element of the button subsribe a0e26bb
• change: title inschrijven to lid worden on button.svelte the todo added of the arrow and add border on button and i c... b71b612
• refactor: remove unnessary code and Fix #202 the button component is now used the only thing what is missing is the a... 2aad45d
• refactor: remove unnessary code and Fix https://github.com/fdnd-agency/voorhoede/issues/202 the button component is n... 5a07fa6
• Refactor: use prettier for ocde indenting 871f162
• refactor: remove unused subscribe button component 6a9d134
• change Error to error this was a unnessary chang 785083d
• Change:add . to class and reformat code for line indenting 244884e
• change px to rem b258706
• tring to use snippet 967a5fc
• Feature:arrow is added must be only places next to the button otherwise remove arrow dae1c04
• Feature:arrow is added must be only places next to the button otherwise remove arrow e930cef
• remove arrow e1e18c4
• Merge pull request #67 from lisagjh/230-textarea-is-double-form-issues Remove Subcribe button and change it to the b... be66fce

View on GitHub

yujing-student closed a pull request on lisagjh/voorhoede

January 22, 2025 2:39pm

Remove Subcribe button and change it to the button component

<h1>What does this change</h1> With this issue I have fix https://github.com/fdnd-agency/voorhoede/issues/230 and issue https://github.com/fdnd-agency/voorhoede/issues/202 I removed the `Subs...

yujing-student created a review comment on a pull request on lisagjh/voorhoede

January 22, 2025 2:38pm

This is now em

View on GitHub

yujing-student created a review on a pull request on lisagjh/voorhoede

January 22, 2025 2:38pm

View on GitHub

yujing-student created a comment on an issue on fdnd-agency/voorhoede

January 22, 2025 2:19pm

_**Gezamelijk Bespreken**_ ## Wat was ons doel? Is dit bereikt? Ons gezamelijke doel is om 3 werkende pagina's op te leveren. ## Hoe ging de samenwerking? De samenwerking ging goed. Jason is he...

View on GitHub

yujing-student deleted a branch fdnd-agency/voorhoede

January 22, 2025 1:59pm

144-fixen/form-component-to-seperate-input-components

yujing-student closed an issue on fdnd-agency/voorhoede

January 22, 2025 1:57pm

keyboard test members page

de title members is skipped the screenreader is skipping the h1 leden this is the only issue on this page https://github.com/user-attachments/assets/82ea1c68-1439-4d6a-a849-c69dfafe6dc2

yujing-student closed an issue on fdnd-agency/voorhoede

January 22, 2025 1:57pm

Take a look into choosing the right varibale type, const or let

yujing-student closed an issue on fdnd-agency/voorhoede

January 22, 2025 1:56pm

issue members page hiring must be under werknemers

Hiring must be under 20 werknemers and there is missing a hover. 

yujing-student closed an issue on fdnd-agency/voorhoede

January 22, 2025 1:56pm

The screenreader is skipping the company possible

the h3 is skipped this can be better in a li element  ![Image](https://github.com/user-attachments/assets...

yujing-student pushed 1 commit to 230-textarea-is-double-form-issues lisagjh/voorhoede

January 22, 2025 12:59pm

• remove arrow e1e18c4

View on GitHub

yujing-student closed a pull request on lisagjh/voorhoede

January 22, 2025 12:32pm

221 refactor this with promiseall making it more concise and refactor the server.js on the homepage

<h1>What does this change</h1> With this issue I have fix https://github.com/fdnd-agency/voorhoede/issues/221 and https://github.com/fdnd-agency/voorhoede/issues/221 I change the let to const...

yujing-student closed a pull request on lisagjh/voorhoede

January 22, 2025 12:31pm

Fix/intro section margin padding

<h1>What does this change</h1> With this issue I have fix https://github.com/fdnd-agency/voorhoede/issues/218. I change the padding and the margin on the `intro.section.svelte` and I used a m...

yujing-student pushed 1 commit to 230-textarea-is-double-form-issues lisagjh/voorhoede

January 22, 2025 9:40am

• Feature:arrow is added must be only places next to the button otherwise remove arrow e930cef

View on GitHub

yujing-student pushed 1 commit to 230-textarea-is-double-form-issues lisagjh/voorhoede

January 22, 2025 9:40am

• Feature:arrow is added must be only places next to the button otherwise remove arrow dae1c04

View on GitHub

yujing-student pushed 1 commit to 230-textarea-is-double-form-issues lisagjh/voorhoede

January 22, 2025 9:37am

• tring to use snippet 967a5fc

View on GitHub

yujing-student pushed 2 commits to 230-textarea-is-double-form-issues lisagjh/voorhoede

January 22, 2025 9:30am

• Change:add . to class and reformat code for line indenting 244884e
• change px to rem b258706

View on GitHub

yujing-student created a review comment on a pull request on lisagjh/voorhoede

January 22, 2025 9:14am

Great that you saw this I have change this in my last commit.

View on GitHub

yujing-student created a review on a pull request on lisagjh/voorhoede

January 22, 2025 9:14am

View on GitHub

yujing-student created a review comment on a pull request on lisagjh/voorhoede

January 22, 2025 9:13am

You are right I forgot to remove unnessary the media query.

View on GitHub