Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
tyler-foster created a review on a pull request on simularium/simularium-viewer
Could this also be fixed by putting `this.downloadfile = this.downloadfile.bind(this)` in the constructor?
tyler-foster created a comment on a pull request on simularium/simularium-website
> I'm not very familiar with this use of the word smelly. As in, is this a "code smell"? > Is it smelly because it doesn't get used yet, so the purpose isn't clear? Or smelly because you don'...
tyler-foster created a review comment on a pull request on aics-int/aics-file-upload-app
Yeah, good point. There should be at least one place around here where the `subfiles` property is used to do some math - let's make sure there's a check, wherever that happens, for the existence of...
tyler-foster created a review comment on a pull request on aics-int/aics-file-upload-app
Since this field ended up being `multifile` instead of `isMultifile`, maybe we should explicitly check this as `fssJob.serviceFields?.multifile === true`?
tyler-foster created a review on a pull request on simularium/simularium-website
LGTM. Is it smelly for this to exist? Seems a little curious, but I'd need a better understanding of how `UIDisplayData` gets used to really comment on it.
tyler-foster opened an issue on AllenInstitute/biofile-finder
Downloads from FMS staging data source fail with 404
This is an issue I see when trying to download files that were uploaded via the File Upload App to the staging environment. I'm not seeing this issue in production. What I see: <img width="1512...
tyler-foster created a review comment on a pull request on aics-int/aics-file-upload-app
I'm afraid I still don't quite understand. > by setting it to undefined we can see more easily if some new modification shows up ie defaulting to true or false Is setting `should_be_in_local`...
tyler-foster created a review comment on a pull request on simularium/simularium-website
Is that paren supposed to be closed? I see `rotate(180deg`, not `rotate(180deg)`
tyler-foster created a review comment on a pull request on simularium/simularium-website
Cheeky, but I'm not complaining.
tyler-foster created a review on a pull request on simularium/simularium-website
Thanks for the overview yesterday! It really helped me understand what I was looking at. LGTM. I really like this PR as a concept. Reactive embed controls are a good idea. +1 to the idea of u...
tyler-foster created a review on a pull request on simularium/simularium-website
Thanks for the overview yesterday! It really helped me understand what I was looking at. LGTM. I really like this PR as a concept. Reactive embed controls are a good idea. +1 to the idea of u...
tyler-foster created a review on a pull request on simularium/binding-sim-edu
Tested it a bit, as far as I can tell it looks like it's working as intended. See one comment about a `name` now being `""`
tyler-foster created a review on a pull request on simularium/binding-sim-edu
Tested it a bit, as far as I can tell it looks like it's working as intended.
tyler-foster created a review comment on a pull request on simularium/binding-sim-edu
FWIW I'm not even sure what this `trace` var is supposed to be in the first place. What is this array type?
tyler-foster created a review comment on a pull request on simularium/binding-sim-edu
No name anymore?