Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
toloudis created a review comment on a pull request on simularium/simularium-viewer
This was befuddling me too. The weird extra export statement makes sense and is also disappointing at the same time.
toloudis created a review comment on a pull request on simularium/simularium-viewer
thank you for this! I was wondering how best to handle it
toloudis created a review comment on a pull request on allen-cell-animated/agave
The modulo allows me to have more than 256 label values and the colors will just wrap around when it's exceeded.
toloudis created a review comment on a pull request on allen-cell-animated/agave
yeah it is 0 or 1. because i'm using float I wanted to do the most obvious check. I've had trouble in the past on gpu drivers with this being finicky about perfect equality.
toloudis created a review comment on a pull request on allen-cell-animated/agave
hm this code is potentially super useful for debugging so rather than delete I'll make it a function that never gets called.
toloudis created a review comment on a pull request on allen-cell-animated/agave
Yes! each channel can have its own colormap! 🎉
toloudis created a review comment on a pull request on allen-cell-animated/agave
This is a opengl thing. Binding texture 0 means no texture is bound. I don't think openGL has a special enum for this
toloudis created a review comment on a pull request on allen-cell-animated/agave
This is added as a copy/paste convenience. I'll remove username before merging, although I am not worried from a security standpoint
toloudis created a review comment on a pull request on allen-cell-animated/agave
You generally have to recalculate u because the first u is not guaranteed perpendicular to BOTH of v and n.
toloudis created a review comment on a pull request on allen-cell-animated/agave
actually I believe denom close to 0 means ray is parallel to plane, not orthogonal
toloudis created a review comment on a pull request on allen-cell-animated/agave
There is an "enable" check box a few lines after this. Show and Use (Enable) are independent actions.
toloudis created a review comment on a pull request on allen-cell-animated/agave
I think the pos data stored by the clip plane tool doesn't have to precisely match the m_plane anymore. At init, I forget why I commented this out (and it may just be because I needed an epsilon)....
toloudis created a review comment on a pull request on allen-cell-animated/agave
songho pages have tons of good math explanations of key 3d graphics stuff. The page deriving projection matrices is great too.