Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
toloudis pushed 1 commit to feature/add-clip-plane allen-cell-animated/agave
- one more try at windows compile f2d5680
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
NaNs are pretty unexpected, I think. Certainly out of scope for this PR.
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
The change above here seems like it would alter the rendering results for pathtrace. It's being divided by 255 which makes me think it's expected to be in the 0-255 range... Did you test the befor...
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
another nice way to do this loop is to initialize min and max to data[0] and then iterate from 1 to length.
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
why would this return something other than 0 if NBINS changed?
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
future idea: it could save a bit of computation if we cached the min and max!
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
I think restating "original raw data" is unnecessary here in the above comments. You could just say "data". A Histogram is being given data values and the histogram is a collection of statistics a...
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
what does "nonzero bin with at least 1 sample" mean? Are "nonzero" and "at least 1 sample" meant to mean the same thing?
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
I feel like `data` (or `channel`) is a better prefix than `raw` here... raw implies to me that some postprocessing will be done to make it less raw later.
toloudis pushed 1 commit to feature/add-clip-plane allen-cell-animated/agave
- more explicit array ctor? 8b52f08
toloudis pushed 1 commit to feature/thick-lines allen-cell-animated/agave
- abstraction for different flavors of gui shaders 98ee78e
toloudis pushed 1 commit to feature/add-clip-plane allen-cell-animated/agave
- try explicit template args 5a0b663
toloudis created a review on a pull request on bioio-devs/bioio-imageio
Awesome if this fixes it - should imageio (or bioio-imageio?) automatically install ffmpeg or is it a known thing that users have to install it themselves?
toloudis pushed 1 commit to feature/add-clip-plane allen-cell-animated/agave
- try windows 2019 c47d76e
toloudis pushed 1 commit to feature/add-clip-plane allen-cell-animated/agave
- bump tensorstore again e2c85a3
toloudis created a comment on a pull request on AllenCellModeling/czi-to-ome-xslt
Oh also maybe a unit test for this would be interesting.
toloudis created a review on a pull request on AllenCellModeling/czi-to-ome-xslt
Not sure if indenting got messed up between line 97 and 98 but the content looks reasonable to me.
toloudis created a review comment on a pull request on AllenCellModeling/czi-to-ome-xslt
@BrianWhitneyAI want to open a separate ticket to review our naming/usage to make sure this is satisfied everywhere?
toloudis created a review comment on a pull request on bioio-devs/bioio-imageio
S is not scene, it's "Samples", as in 3 means RGB and 4 means RGBA
toloudis pushed 3 commits to main allen-cell-animated/volume-viewer
toloudis closed a pull request on allen-cell-animated/volume-viewer
update actions/cache and node20
`actions/cache` v1 is deprecated and notices are going out. This PR updates it to v4 and also bumps our node version for all our CI actions. For info about the deprecation see https://github.co...