Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
toloudis created a review comment on a pull request on allen-cell-animated/website-3d-cell-viewer
I agree, I'll do that
toloudis created a review comment on a pull request on allen-cell-animated/website-3d-cell-viewer
I did test this and I think it makes a minor difference in channel load order but we still get correct results either way. I am inclined to leave it in. The only scenario I would worry about is t...
toloudis created a review comment on a pull request on allen-cell-animated/website-3d-cell-viewer
this should pick up the fixes in volume-viewer
toloudis pushed 1 commit to fix/closed-loader allen-cell-animated/website-3d-cell-viewer
- bump volume-viewer version c49bbdd
toloudis pushed 4 commits to main allen-cell-animated/volume-viewer
toloudis closed a pull request on allen-cell-animated/volume-viewer
Bug fix for Json images, and remove image
Two very small changes toward fixing some issues in CFE with loading images by clicking Gallery. 1. Volumes were never being truly removed from the View3d. The problem with that is that you cou...
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
right. "in" roughly means "is a property key for", which for arrays just means the array indices. This took me a while to track down, because ordinarily we request all channels but I made a chang...
toloudis created a review comment on a pull request on allen-cell-animated/website-3d-cell-viewer
the only change in this file is this one which is basically a "null check".. at some point during debugging this, there was a condition where empty channelData was coming in here.
toloudis created a review comment on a pull request on allen-cell-animated/website-3d-cell-viewer
this error output to console seemed very useful
toloudis created a review comment on a pull request on allen-cell-animated/website-3d-cell-viewer
the above set of lines 447-460 actually explicitly selects channels to load. I'm not certain of whether this is necessary, will test one more time without it. I think it makes a difference when sw...
toloudis created a review comment on a pull request on allen-cell-animated/website-3d-cell-viewer
The above lines use a new criterion to test whether to use old or new/defaulted channel settings. It uses the remapped display name after the getCurrentViewerChannelSettings are applied, instead o...
toloudis pushed 1 commit to fix/closed-loader allen-cell-animated/website-3d-cell-viewer
- add comment be91199
toloudis pushed 1 commit to fix/closed-loader allen-cell-animated/website-3d-cell-viewer
- clean up d0500e5
toloudis pushed 1 commit to fix/closed-loader allen-cell-animated/website-3d-cell-viewer
- cleanup 309b1cb
toloudis pushed 1 commit to fix/closed-loader allen-cell-animated/website-3d-cell-viewer
- undo a couple of extra changes bec9383
toloudis opened a draft pull request on allen-cell-animated/website-3d-cell-viewer
Fix/closed loader
Problem ======= What is the problem this work solves, including [Link to story or ticket](https://my-tracking-system.url/ticket-number) Solution ======== What I/we did to solve this problem...
toloudis pushed 1 commit to fix/closed-loader allen-cell-animated/website-3d-cell-viewer
- logging df1cfb9