Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
toloudis created a review comment on a pull request on allen-cell-animated/colorizer-data
```suggestion Defaults to "Centroid Y."" ```
toloudis created a review comment on a pull request on allen-cell-animated/colorizer-data
need linting and formatting checks?
toloudis created a review comment on a pull request on allen-cell-animated/colorizer-data
I feel like this would be cleaner if you could do `config.track_column` etc
toloudis created a review on a pull request on allen-cell-animated/colorizer-data
a few comments but the single-function-call converter is looking nice
toloudis created a review on a pull request on allen-cell-animated/colorizer-data
a few comments but the single-function-call converter is looking nice
toloudis pushed 48 commits to main allen-cell-animated/agave
- add basic clip plane stubs and shader impl 2ff0c80
- allow clip plane to draw itself somewhere eaa1c53
- think about enabling rotate mode with anything selected dc69e6a
- rename manip mode 87ef192
- move selection into appscene? 91d58be
- check out a way to have selection happen 7aee014
- wire up selection to go through QRenderSettings and decouple rotate gizmo from selection ef96eba
- more work on decoupling selection from manipulation c86fb3a
- wip toggle buttons db4bf04
- cleanup and debugging ac0f784
- vscode config fa47d65
- remove a few debug logs 3dcb3d4
- try updating the plane bc1b65b
- position plane drawing consistently ba3e7ac
- tweaking plane transform 8247f22
- clean up the plane math a little bit b274919
- more tweaking 6c12b60
- adjust appearance of clip plane ff0143d
- manipulator management and more clip plane control dbc3855
- fix plane transformation 7c3e30b
- and 28 more ...
toloudis pushed 1 commit to feature/refactor-for-clip-plane allen-cell-animated/agave
- Update agave_app/GLView3D.cpp Co-authored-by: Peyton Lee <[email protected]> e99eb45
toloudis pushed 22 commits to main allen-cell-animated/agave
- start adding a clipping plane b09bec0
- fix naming d32e32f
- fix compiler f806dc0
- fix shader again beec01c
- add transform of clip plane from world to view space 92a4ce6
- try using the clip plane in world space 69a967d
- got most of the clipping math correct here 80ba734
- start: make scene selection generic so we can show rotation widgets for different types of objects f3e1ac4
- add a scene object for clip plane b69593a
- refactor: area light tool is not a special case anymore and is instead part of selection mechanism 40b5daf
- cleanup, and sceneplane provides clipplanetool 45a0a18
- cleanup 7579521
- cleanup bd976b4
- cleanup cb56ce6
- remove clipplane implementation 1467a6f
- removed clip plane files for now 6a8c243
- remove clipplane controls for now dd2a008
- cleanup 60bd0f8
- remove clip plane for this branch 7b009b8
- use helper functions to avoid hardcoded light indices 79abf5e
- and 2 more ...
toloudis closed a pull request on allen-cell-animated/agave
Feature/refactor selection manipulator
Review time: medium. This is preliminary work before adding a user clip plane that we want to let the user interactively position and rotate. This PR should cause no behavior changes to the app...
toloudis created a review on a pull request on simularium/simularium-website
I don't know technically why onClick is better than clickHandler or whether there's any difference at all. Apart from that, if everything's working, I approve!
toloudis pushed 1 commit to fix/volume-clipping-tests simularium/simularium-viewer
- try fixing coverage 323c295
toloudis created a review comment on a pull request on simularium/simularium-viewer
one of our ci tests was flagging that as an expression that does nothing, so I removed it. I have no idea how it got there in the first place.
toloudis created a review comment on a pull request on simularium/simularium-viewer
this line that predefines the vitest globals probably should only be enabled when we are running tests (separate tsconfig for tests)
toloudis created a review comment on a pull request on simularium/simularium-viewer
excepted harmless name change. It appears as fileName everywhere else.
toloudis pushed 1 commit to fix/volume-clipping-tests simularium/simularium-viewer
- fix bad merge w.r.t. rebasing to main 8ef8890
toloudis created a comment on a pull request on manzt/zarrita.js
Well we went for it and got rid of Jest in favor of vitest and everything is working. I am fine to close this PR. Thanks again for the info and for the great library.
toloudis closed a pull request on manzt/zarrita.js
add default exports to all packages
We are using Jest to do unit tests on a project that is newly integrating with some code that imports zarrita. Jest simply can not resolve zarrita imports and we determined that it's because jest ...
toloudis opened a pull request on allen-cell-animated/volume-viewer
Feature/rename package
Mainly we need to update the npm package as part of renaming Vol-E. * rename npm package to `@aics/vole-core` * revise/update README * remove react example as it was horribly out of date * re...
toloudis pushed 1 commit to feature/rename-package allen-cell-animated/volume-viewer
- update package-lock 9e1bd49
toloudis created a review comment on a pull request on allen-cell-animated/agave
I honestly can't remember right now but it could be because of changes in AppScene or things that AppScene includes, too. Sometimes it's easy to just include extra header files that never get used...