Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
toloudis pushed 1 commit to feature/clip-plane allen-cell-animated/agave
- remove a few debug logs 3dcb3d4
toloudis created a comment on an issue on allen-cell-animated/agave
Some work has been done on toolbars. Closing this until we have another concrete work item to do
toloudis closed an issue on allen-cell-animated/agave
Toolbar redesign
## Use Case Toolbar buttons should have icons and need to be organized more logically. ## Solution UX design. Some buttons may have menu-like behaviors.
toloudis closed an issue on allen-cell-animated/agave
3d viewport toolbar design
### Background agave toolbar is currently a single "main app" toolbar which comprises a variety of different categories of commands: file loading, file saving, rendering to image file, and viewp...
toloudis opened an issue on allen-cell-animated/agave
user clip plane
One additional user-controlled clipping plane can let users see into cross sections of specific interest. Add a clip plane as a grid that can be drawn in viewport. Allow the clip plane to be rotat...
toloudis pushed 1 commit to feature/clip-plane allen-cell-animated/agave
- check out a way to have selection happen 7aee014
toloudis pushed 1 commit to feature/clip-plane allen-cell-animated/agave
- move selection into appscene? 91d58be
toloudis pushed 1 commit to feature/clip-plane allen-cell-animated/agave
- think about enabling rotate mode with anything selected dc69e6a
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
I think this could use an extra comment up above to say what r,g,b,a of the position texture are expected to represent. You might even mention that this is a data format contract with Simularium ...
toloudis created a review comment on a pull request on allen-cell-animated/volume-viewer
naming is a little weird here as this value might not be in view space yet
toloudis created a review on a pull request on allen-cell-animated/volume-viewer
Good stuff! Looks like you didn't even have to manipulate the value. I recommend a clarifying comment and maybe a variable rename.
toloudis created a review on a pull request on allen-cell-animated/volume-viewer
Good stuff! Looks like you didn't even have to manipulate the value. I recommend a clarifying comment and maybe a variable rename.
toloudis pushed 1 commit to feature/clip-plane allen-cell-animated/agave
- allow clip plane to draw itself somewhere eaa1c53
toloudis created a review comment on a pull request on allen-cell-animated/agave
Honestly the way the light sources are handled right now is still sloppy in part because SceneObject (and SceneLight) is a new thing to this codebase. A future PR will need to clean up the creatio...
toloudis opened an issue on allen-cell-animated/agave
try c++20
## Use Case c++20 has some good new stuff in the STL see if we can compile using c++20 in cmakelists.txt top level
toloudis created a review comment on a pull request on allen-cell-animated/agave
Yeah this is a bit funky but a well established pattern. The std::remove actually shifts the queried object (`tool`) to the end of the vector `m_tools` and returns an iterator to the start of the ...
toloudis created a review comment on a pull request on allen-cell-animated/agave
The origins class is "prepared" to hold an array of objects but currently only the first object is ever active. The idea being that you could have multiple objects selected and then rotate or tran...
toloudis created a review comment on a pull request on allen-cell-animated/agave
yeah this is just a throw-in for a lint warning I was seeing about uninitialized data. I don't think the value is even used anywhere currently. could be used for depth-of-field blurring or adapti...
toloudis created a review comment on a pull request on allen-cell-animated/agave
yeah currently one could do that. It could happen if data were saved out badly, or corrupted after being saved, but I think that's the only way. I could nail things down even more, of course.
toloudis opened a draft pull request on allen-cell-animated/agave
add basic clip plane stubs and shader impl
**Pull request recommendations:** - [ ] Name your pull request _your-development-type/short-description_. Ex: _feature/read-tiff-files_ - [ ] Link to any relevant issue in the PR description. E...
toloudis pushed 8 commits to feature/clip-plane allen-cell-animated/agave
- remove clipplane implementation 1467a6f
- removed clip plane files for now 6a8c243
- remove clipplane controls for now dd2a008
- cleanup 60bd0f8
- remove clip plane for this branch 7b009b8
- use helper functions to avoid hardcoded light indices 79abf5e
- holdout more clipplane stuff 77004e5
- add basic clip plane stubs and shader impl 2ff0c80