Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
slaizet created a review comment on a pull request on xcompact3d/x3d2
We might want to have a discussion about how to handle two different Poisson solvers (at compilation or at runtime or something else), in terms of user friendliness, performance, and ease of implem...
slaizet created a comment on an issue on openjournals/joss-reviews
All boxes ticked now for me. Best, Sylvain Sylvain LAIZET Professor in Computational Fluid Mechanics Dept. of Aeronautics, Imperial College London, UK ________________________________ ...
slaizet pushed 1 commit to fix-allreduce-with-inplace xcompact3d/Incompact3d
- small typo fixed in acl_source 15d27fa
slaizet created a review comment on a pull request on xcompact3d/Incompact3d
I will have a look and fix the typo
slaizet created a review comment on a pull request on xcompact3d/Incompact3d
possibly a typo on my side :-)
slaizet opened a pull request on xcompact3d/Incompact3d
Fix allreduce with inplace
This is to deal with issue #287 I have listed 186 ALLREDUCE operations in the codebase. 181 of them are now using MPI_IN_PLACE for clarity. Only 5 of them are not using MPI_IN_PLACE. I have ...
slaizet pushed 1 commit to fix-allreduce-with-inplace xcompact3d/Incompact3d
- finishing implementation of MPI_IN_PLACE 30e0c98
slaizet pushed 7 commits to fix-allreduce-with-inplace xcompact3d/Incompact3d
- Move stretching subroutines to a dedicated module and fix undefined ypraf values (#314) * Move stretching suborutine... afdf902
- Add DEBG macro to DEBUG builds DEBUG builds will add both the DEBG and DEBUG macros bb3183f
- Make CMake add -cpp 41e301a
- Apparently GNU doesn't support -g3, replace with -g 33f59ab
- The poisson module needed to use decomp_2d_mpi : nrank However refinement_matrice was already using the variable wit... bb2a111
- Merge pull request #317 from xcompact3d/pbartholomew08-patch-1 Add DEBG macro to DEBUG builds 1bfe7e5
- mpi_in_place implementation in allreduce 501011b
slaizet pushed 5 commits to master xcompact3d/Incompact3d
- Add DEBG macro to DEBUG builds DEBUG builds will add both the DEBG and DEBUG macros bb3183f
- Make CMake add -cpp 41e301a
- Apparently GNU doesn't support -g3, replace with -g 33f59ab
- The poisson module needed to use decomp_2d_mpi : nrank However refinement_matrice was already using the variable wit... bb2a111
- Merge pull request #317 from xcompact3d/pbartholomew08-patch-1 Add DEBG macro to DEBUG builds 1bfe7e5
slaizet closed a pull request on xcompact3d/Incompact3d
Add DEBG macro to DEBUG builds
DEBUG builds will add both the DEBG and DEBUG macros
slaizet pushed 1 commit to fix-allreduce-with-inplace xcompact3d/Incompact3d
- adding mpi_in_place for allreduce operations d7e54ad
slaizet created a review comment on a pull request on xcompact3d/Incompact3d
happy to, but I do not know what the special case is :-) I was not able to get a special case!
slaizet created a branch on xcompact3d/Incompact3d
fix-allreduce-with-inplace - Current CPU version of our solver for the Navier-Stokes equations
slaizet closed an issue on xcompact3d/Incompact3d
IBM - Invalid memory access in special cases (iibm=3)
The present issue is specific to IBM simulations with spline reconstruction (`iibm=3`). The variable `ipol` can be used without being defined. This issue can lead to undefined behavior and out of b...
slaizet pushed 2 commits to master xcompact3d/Incompact3d
slaizet closed a pull request on xcompact3d/Incompact3d
fix bug #294 (ibm out of memory problem with iibm=3)
slaizet opened a pull request on xcompact3d/Incompact3d
fix bug #294 (ibm out of memory problem with iibm=3)
slaizet created a branch on xcompact3d/Incompact3d
fix_ibm3 - Current CPU version of our solver for the Navier-Stokes equations
slaizet created a comment on a pull request on xcompact3d/Incompact3d
I like the idea of having some stretching-specific parameters to a dedicated module and also a dedicated f90 file for all stretching related subroutines.
slaizet created a comment on an issue on xcompact3d/Incompact3d
okay, so still no luck in having `xi(i,j,k).eq.xf(i,j,k)` so I suggest we comment the "special case" situation in the three spatial direction. That will remove the invalid memory access.
slaizet created a comment on an issue on openjournals/joss-reviews
Hi all, I am happy to go ahead with the publication for this software. Cheers, Sylvain
slaizet created a comment on an issue on xcompact3d/Incompact3d
@mathrack would you have an input file for which you go into those special cases?
slaizet created a comment on an issue on xcompact3d/Incompact3d
The code does not support yet periodicity+stretching, but it will eventually :-) Anyway, even with non-periodic condition, the refinement procedure for the refined mesh is not great, hence why I th...