Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sipsorcery created a comment on a pull request on sipsorcery-org/sipsorcery
Fair enough and if performance is a primary requirement there are C/C++ projects (pjsip, kamailio etc) that will always out perform a managed application environment. My point here is that while...
sipsorcery created a review comment on a pull request on sipsorcery-org/sipsorcery
I'm struggling to see why the emphasis on such fine grained optimisations (in itself an [anti-pattern](https://wiki.c2.com/?PrematureOptimization)). This part of the code is dealing with the SIP si...
sipsorcery pushed 1 commit to master sipsorcery-org/sipsorcery
- Added back GetEpoch extension method as obsolete just in case. (#1326) e2cab8f
sipsorcery closed a pull request on sipsorcery-org/sipsorcery
Added back GetEpoch extension method as obsolete just in case.
sipsorcery opened a pull request on sipsorcery-org/sipsorcery
Added back GetEpoch extension method as obsolete just in case.
sipsorcery created a branch on sipsorcery-org/sipsorcery
obsolete-getepoch - A WebRTC, SIP and VoIP library for C# and .NET. Designed for real-time communications apps.
sipsorcery pushed 1 commit to master sipsorcery-org/sipsorcery
- Rename and reimplement the Unix time conversion function (#1325) * Use a more idiomatic approach to convert a DateTi... 1feafa5
sipsorcery closed a pull request on sipsorcery-org/sipsorcery
Rename and reimplement the Unix time conversion function
* Use a more idiomatic approach to convert a DateTime to Unix time, and add a unit test. * Rename the function GetEpoch() to ToUnixTime(), as is this function doesn't return the epoch, but the nu...
sipsorcery created a review comment on a pull request on sipsorcery-org/sipsorcery
So in this PR the only change is `|| find.Length == 0` (and the unit test, whic is always appreaciated)?
sipsorcery created a comment on a pull request on sipsorcery-org/sipsorcery
The flag enum is a good improvement. Happy to merge. The change is highly unlikely to affect any library users. If there are further string optimisations planned it would be better to get them i...
sipsorcery created a review on a pull request on sipsorcery-org/sipsorcery
I appreciate it's a subjective choice but given I'm curently the one that spends the most time on the code base I prefer the explicit boolean checks. `AudioStream.LocalTrack.NoDtmfSupport == fal...
sipsorcery created a review comment on a pull request on sipsorcery-org/sipsorcery
Given this is being refactored why not make it even readable: ``` return value.ToLowerInvariant() is "cancelled" or "error" ...
sipsorcery pushed 1 commit to master sipsorcery-org/sipsorcery
- To parse enums, use TryParse() instead of Parse() in a try block. (#1320) * To parse enums, use TryParse() instead o... c1439b3
sipsorcery closed a pull request on sipsorcery-org/sipsorcery
To parse enums, use TryParse() instead of Parse() in a try block.
To parse enums, it is recommended to use TryParse(). This is more C# idiomatic, and it avoids declaring a try/catch block, which has a performance cost.
sipsorcery pushed 1 commit to master sipsorcery-org/sipsorcery
- Use "N" formatting option in Guid.ToString() instead of replacing characters. (#1319) a481acd
sipsorcery closed a pull request on sipsorcery-org/sipsorcery
Use "N" formatting option in Guid.ToString() instead of replacing characters
There is already the format option "N" in the ToString() method of type Guid to perfom this kind of formatting. This makes the code lighter, and is more performant as it saves string allocations an...
sipsorcery pushed 1 commit to master sipsorcery-org/sipsorcery
- Fix a few typos found while reading the code. (#1318) 7c8f0a5
sipsorcery closed a pull request on sipsorcery-org/sipsorcery
Fix a few typos found while reading the code.
Hi, I recently discovered this project while tinkering on a side project. I'm impressed by the amount of work that has been done. Congrats to the project leader and the contributors. I submit...
sipsorcery created a comment on an issue on sipsorcery-org/sipsorcery
Do you mean removing the block below? That would make sense to me. I'd say the only exception would be if there is only a single media stream it should be returned but then that could be the first ...
sipsorcery pushed 1 commit to master sipsorcery-org/sipsorcery
- Fix logic flow in DtlsSrtpTransport.cs (#1316) * fix stream retrieval bug RTC updates * add translations for tray a... 7e0ef7d
sipsorcery closed a pull request on sipsorcery-org/sipsorcery
Fix logic flow in DtlsSrtpTransport.cs
Quite often I get exceptions in this method where it's closed before the handshake has completed so GetMillisecondsRemaining uses 1/1/0001 and returns a timeout of -2147463647 and throws a TimeoutE...