Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
shaavan created a comment on a pull request on lightningdevkit/rust-lightning
**Updated** from [pr3412.12](https://github.com/shaavan/rust-lightning/commits/pr3412.12) to [pr3412.13](https://github.com/shaavan/rust-lightning/commits/pr3412.13) ([diff](https://github.com/shaa...
shaavan pushed 264 commits to offersmessageflow shaavan/rust-lightning
- Add `lightning-liquidity` crate to the workspace We upstream the `lightning-liquidity` into the `rust-lightning` wor... b8b8071
- Avoid allocating during `LSPSMethod` serialization 94c1e37
- Use `split_off` instead of collecting in `get_pending_events()` d8ba98b
- Use LDK-internal Hash{Map,Set} types in `lightning-liquidity` 3a8e1bf
- Use `lightning::sync` via symlink in `lightning-liquidity` .. to which end we also need to make some additions to `d... 9c9b4a8
- Upper-bound the event queue size We add a size limit on the event queue, after which we'll just start dropping event... 7e42b36
- LSPS2: Introduce `MAX_PENDING_REQUESTS_PER_PEER` service limit We introduce a new `MAX_PENDING_REQUESTS_PER_PEER` li... 3f2e232
- LSPS2: DRY up pending request insertion/removal .. which is a prefactor to also start checking the total number of p... 1f13c80
- LSPS2: Enforce a limit on total pending requests To this end we introduce a new counter keeping track of overall req... f75f124
- LSPS2: Clean pending `get_info` request state on disconnection We clean up any `get_info` request state when peers d... 6451a43
- Define `MigratableKVStore` trait with `list_all_keys` method .. which will be used for generic `KVStore`-to-`KVStore... 91ae8b8
- Always require a `PeerState` for the CP when claiming an HTLC Now that we track the latest `ChannelMonitorUpdate::up... f9765c4
- Fix outdated static invoice docs. 43029bf
- Don't take() outbound invoice requests on retry Prior to this patch, we would take() the invoice request stored for ... 605cc3c
- Fix failure to abandon async payments on invalid static invoice Prior to this fix, we would attempt to mark outbound... 08d81fb
- Make create_blinded_payment_paths methods amount optional. Useful for creating payment paths for static invoices whi... e810075
- Factor invoice expiry into blinded path max_cltv_expiry Will be useful for static invoices' blinded paths, which may... 542deeb
- Add PaymentContext for async payments This context is stored in the blinded payment paths we put in static invoices ... 84f200f
- Set closed chan mon upd `update_id`s at creation not application In c99d3d785dd78f594837d283636b82222c3b9ef1 we adde... 1481216
- Add an additional variant to `handle_new_monitor_update!` In d1c340a0e1f988e0414aa5425f7c76e515ada6dd we added suppo... 3395938
- and 244 more ...
shaavan created a tag on shaavan/rust-lightning
pr3412.13 - A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
shaavan pushed 2 commits to omf-27 shaavan/rust-lightning
shaavan pushed 2 commits to omf-27 shaavan/rust-lightning
shaavan created a branch on shaavan/rust-lightning
omf-27 - A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
shaavan pushed 20 commits to main shaavan/rust-lightning
- `rustfmt`: Run on `lightning/src/onion_message/functional_tests.rs` 3c3e93e
- `rustfmt`: Drop `lightning/src/onion_message/functional_tests.rs` from exclusion list 7f90d91
- `rustfmt`: Run on `lightning/src/onion_message/messenger.rs` ecbab29
- `rustfmt`: Drop `lightning/src/onion_message/messenger.rs` from exclusion list 45dbcc4
- `rustfmt`: Run on `lightning/src/onion_message/offers.rs` b98f070
- `rustfmt`: Drop `lightning/src/onion_message/offers.rs` from exclusion list 682cf76
- `rustfmt`: Run on `lightning/src/onion_message/packet.rs` 5e86117
- `rustfmt`: Drop `lightning/src/onion_message/packet.rs` from exclusion list 5d9ee8a
- `rustfmt`: Run on `lightning/src/onion_message/mod.rs` 90e1510
- `rustfmt`: Drop `lightning/src/onion_message/mod.rs` from exclusion list 6c0c5f0
- Use channel ID over funding outpoint to track monitors in ChainMonitor Once dual funding/splicing is supported, chan... d205d8d
- Use channel ID over funding outpoint to track monitors in ChannelManager As motivated by the previous commit, we do ... e8854f9
- Remove funding script return value from ChannelMonitor::get_funding_txo It's not needed except for one place where w... 717db82
- Merge pull request #3554 from wpaulino/channel-monitor-by-channel-id Start tracking ChannelMonitors by channel ID in... 9b66e2c
- Merge pull request #3576 from tnull/2025-01-rustfmt-onion-message `rustfmt`: Run on `onion_message` c7c3973
- Clean up type aliases in `functional_tests` In 3c3e93e7b5a871e57462cc14e0509d271421c88a we ran rustfmt blindly on `l... 0ba12db
- Clean up terrible rustfmt-isms in OM `functional_tests.rs` In 3c3e93e7b5a871e57462cc14e0509d271421c88a we ran rustfm... f8a5ef5
- Use constant for buffer size in OM `functional_tests.rs` In 3c3e93e7b5a871e57462cc14e0509d271421c88a we ran rustfmt ... c45c3a7
- Improve readability in `messenger.rs` now that we're rustfmt'ing In ecbab2938626ceb23bfad7af575638a34f1d6959 we ran ... 04c769b
- Merge pull request #3582 from TheBlueMatt/2025-01-om-rustfmt-followups Followups to `onion_message` rustfmt a91196b
shaavan created a review on a pull request on lightningdevkit/rust-lightning
Overall, LGTM! Since there aren’t any direct code references explaining why we switch to using NodeId in RGS, it might be helpful to add a quick note in the commit message (of ddc332627007467754...
shaavan created a comment on a pull request on lightningdevkit/rust-lightning
**Update:** From [pr3177.30](https://github.com/shaavan/rust-lightning/commits/pr3177.30) to [pr3177.31](https://github.com/shaavan/rust-lightning/commits/pr3177.31) ([diff](https://github.com/shaa...
shaavan pushed 178 commits to padding shaavan/rust-lightning
- Fix outdated static invoice docs. 43029bf
- Don't take() outbound invoice requests on retry Prior to this patch, we would take() the invoice request stored for ... 605cc3c
- Fix failure to abandon async payments on invalid static invoice Prior to this fix, we would attempt to mark outbound... 08d81fb
- Make create_blinded_payment_paths methods amount optional. Useful for creating payment paths for static invoices whi... e810075
- Factor invoice expiry into blinded path max_cltv_expiry Will be useful for static invoices' blinded paths, which may... 542deeb
- Add PaymentContext for async payments This context is stored in the blinded payment paths we put in static invoices ... 84f200f
- Add onion message AsyncPaymentsContext for inbound payments This context is included in static invoice's blinded mes... 96db8aa
- Add utils to create static invoices and their corresponding offers We can't use our regular offer creation util for ... 9898e67
- Test failures on paying static invoices Since adding support for creating static invoices from ChannelManager, it's ... 7d4af6a
- Move blinded keysend tests into new async_payments_tests.rs Blinded keysend is only planned to be supported in the a... d3a7efa
- Allow uppercase bech32 HRP Previously, we would fail parsing `Offer`s if the HRP didn't match our expected (lowercas... 540bcf7
- Add test coverage for upper-/mixed-case `Offer` encodings .. to ensure we're able to decode all-uppercase HRPs and r... 7d653c2
- Fix overly spammy `TRACE` logging in async onion message event handling We recently introduced `TRACE`-level logging... 1c0e463
- Merge pull request #3506 from tnull/2025-01-allow-upperase-hrp-main Allow uppercase bech32 HRP (main) 262d789
- Merge pull request #3508 from tnull/2025-01-fix-spammy-async-om-event-handling-logs-main Fix overly spammy `TRACE` l... 2c0066e
- Add debug implementations for scoring parameters Derives Debug for ProbabilisticScoringFeeParameters and Probabiliti... 48ceefd
- Combine InboundV2Channel and OutboundV2Channel Pending v2 channels will need to be broken up into separate phases fo... 91ff6c1
- Remove InteractivelyFunded trait Now that InboundV2Channel and OutboundV2Channel have been combined into a PendingV2... 270c5ab
- Combine UnfundedInboundV2 and UnfundedOutboundV2 Now that InboundV2Channel and OutboundV2Channel have been combined ... d6637d7
- Hide ChannelPhase::Funded behind as_funded method Exposing ChannelPhase in ChannelManager has led to verbose match s... 1780ce4
- and 158 more ...
shaavan pushed 104 commits to main shaavan/rust-lightning
- Add expected_htlc_destination argument to run_onion_failure_test This argument will be asserted on in a future commi... df9f3c0
- Outbound payments: pass session privs by reference We need to stop passing this Vec by value for the next commit so ... c6f2768
- Fix outbound payments memory leak on buggy router Prior to this patch, if we attempted to send a payment or probe to... b2269f4
- Enable decoding new incoming HTLC onions when fully committed This commit ensures all new incoming HTLCs going forwa... d8d9dc7
- `rustfmt`: Run on `util/scid_utils.rs` 0fc4877
- `rustfmt`: Drop `util/scid_utils.rs` from exclusion list a8a5162
- `rustfmt`: Run on `util/ser.rs` d436cf8
- `rustfmt`: Drop `util/ser.rs` from exclusion list 74d57dc
- `rustfmt`: Prepare `util/ser_macros.rs` 4568db8
- `rustfmt`: Run on `util/ser_macros.rs` 1cc309d
- `rustfmt`: Drop `util/ser_macros.rs` from exclusion list f4f9535
- `rustfmt`: Run on `util/test_channel_signer.rs` fe53ac9
- `rustfmt`: Drop `util/test_channel_signer.rs` from exclusion list 8f335e0
- `rustfmt`: Prepare `util/test_utils.rs` .. we pull out `Mutex` field initialization into dedicated variables as they... 14da64b
- `rustfmt`: Run on `util/test_utils.rs` 12fc953
- `rustfmt`: Drop `util/test_utils.rs` from exclusion list 767646c
- `rustfmt`: Run on `util/time.rs` 5a27316
- `rustfmt`: Drop `util/time.rs` from exclusion list f2bc902
- `rustfmt`: Prepare `util/transaction_utils.rs` 2be14b3
- `rustfmt`: Run on `util/transaction_utils.rs` b9fc8ba
- and 84 more ...
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Since we are `P=30`, marking this as resolved. Thanks a lot for helping me understand the point!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Updated the `TLV_OVERHEAD` in [pr3177.30](https://github.com/shaavan/rust-lightning/commits/pr3177.30) Thanks for the pointer!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Updated the comment describing the reasoning in [pr3177.30](https://github.com/shaavan/rust-lightning/commits/pr3177.30) Thanks for the pointer!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Updated the comment describing the reasoning in [pr3177.30](https://github.com/shaavan/rust-lightning/commits/pr3177.30) Thanks for the pointer!
shaavan created a comment on a pull request on lightningdevkit/rust-lightning
**Update:** From [pr3177.29](https://github.com/shaavan/rust-lightning/commits/pr3177.29) to [pr3177.30](https://github.com/shaavan/rust-lightning/commits/pr3177.30) ([diff](https://github.com/shaa...
shaavan pushed 8 commits to padding shaavan/rust-lightning
- f: Remove Readable for Padding 1fc3a7c
- Update Padding struct to contain padding length. 1. This allows setting the length of padding at the time of writing... dd8a77f
- Introduce `BlindedPathWithPadding` struct Add a generic `BlindedPathWithPadding` struct to handle padding for `Forwa... 6e7fd12
- f: Introduce TLV_OVERHEAD 9fc3082
- Introduce Padding for BlindedMessage Paths. A note of Compact Blinded Paths: Compact Blinded paths are intended to ... e612363
- Introduce Padding for Blinded Payment Paths e09f0df
- f: Change padding value 35 -> 30 fc13f92
- Introduce test for Padding Add test to verify blinded message and payment path padding. 3aa2a1e
shaavan created a tag on shaavan/rust-lightning
pr3177.30 - A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Okay, now I understand! Using 30-byte blocks allows masking ReceiveTlvs with, and without human-readable names and quantity, which a 31-byte block doesn’t. In that case, 30 definitely seems like th...