Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
shaavan created a review on a pull request on lightningdevkit/rust-lightning
Thanks so much for looking out, @valentinewallace and @jkczyz! Really appreciate it! ✨ For the [offers message flow](https://github.com/lightningdevkit/rust-lightning/pull/3412) refactor, the ch...
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Thanks makes sense! Building on that, I was thinking that if we go with **31 instead of 30**, we still keep the benefits of the extra padding block while also avoiding major extra padding for st...
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Hi! Thanks so much for the pointer on TLV overhead. Taking the extra 2 bytes per hop into account (from Type and Length bytes), I reran the analysis ([previous analysis](https://github.com/lig...
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Hi! So, I noticed that changing the serialized value for `old_field` ends up updating `new_field` during deserialization, which makes sense for backward compatibility. That said, I was wonderin...
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Got it! Thanks for the pointer! Will address it in the second part of #3381 solution
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Makes sense! I’ve added a "TODO" comment in the code in [pr2830.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11) and updated the PR description accordingly. Thanks so much for p...
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Done! [pr2830.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11) Thanks for the pointer!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Got it, makes sense! Fixed in [pr2830.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11). Thanks so much for the suggestion! We can use the interface introduced in #3525 to assess...
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Done! [pr2830.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11) Thanks!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Makes sense! Addressed in [pr2830.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11) Thanks a lot for the pointer!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Done! [pr2830.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11) Thanks!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Done! [pr2830.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11) Thanks!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Addressed in [pr2830.11](https://github.com/shaavan/rust-lightning/commits/pr2830.11) Thanks for the pointer!