Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Addressed in [pr3504.05](https://github.com/shaavan/rust-lightning/commits/pr3504.05) Thanks a lot for the pointer!
shaavan created a comment on a pull request on lightningdevkit/rust-lightning
Updated from [pr3504.04](https://github.com/shaavan/rust-lightning/commits/pr3504.04) to [pr3504.05](https://github.com/shaavan/rust-lightning/commits/pr3504.05) ([diff](https://github.com/shaavan/...
shaavan pushed 1 commit to i3381a shaavan/rust-lightning
- Introduce RAA Blocker check in Node::drop() Co-authored by: Matt Corallo <[email protected]> 45aa824
shaavan created a tag on shaavan/rust-lightning
pr3504.05 - A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
With [pr3412.12](https://github.com/shaavan/rust-lightning/commits/pr3412.12), I updated the trait to call `ChannelManager`’s implementation of `create_blinded_paths` instead of moving the function...
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Addressed in [pr3412.12](https://github.com/shaavan/rust-lightning/commits/pr3412.12). Also I have done a similar thing for the rest of the functions! Thanks a lot, for the pointer!
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
Addressed in [pr3412.12](https://github.com/shaavan/rust-lightning/commits/pr3412.12) In the latest updated, I have restructured the commits, so that we move `verify_bolt12_invoice` directly to fl...
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
I'd love to understand your point better. Are you suggesting we could parameterize `Flow` with `Router`, or is there a different approach you’re pointing to?
shaavan created a review comment on a pull request on lightningdevkit/rust-lightning
My initial reasoning was that since `OffersMessageFlow` only uses one function from `NodeSigner` (`sign_bolt12_invoice`), I opted to call it from the `Commons` trait. With this approach, I aimed to...
shaavan created a comment on a pull request on lightningdevkit/rust-lightning
**Updated** from [pr3412.11](https://github.com/shaavan/rust-lightning/commits/pr3412.11) to [pr3412.12](https://github.com/shaavan/rust-lightning/commits/pr3412.12) ([diff](https://github.com/shaa...
shaavan pushed 15 commits to offersmessageflow shaavan/rust-lightning
- f: Add comment about the removed Event abe4df0
- Introduce `OffersMessageFlow` This commit introduces a new struct, `OffersMessageFlow`, to extract all offers messag... 37566ce
- Introduce `OffersMessageCommons` Trait and Implementation A new trait, `OffersMessageCommons`, is introduced to enca... b382bf5
- Refactor `OffersMessageHandler` Implementation to `OffersMessageFlow` This commit introduces the `OffersMessageHandl... 070c03c
- Introduce `AnOffersMessageFlow` - This commit introduces a new struct, `AnOffersMessageFlow`, which generically im... 6753e46
- Move `create_offer_builder` to `OffersMessageFlow` 56c7fad
- Move create_refund_builder to OffersMessageFlow 1738f7c
- Move pay_for_offer to OffersMessageFlow cd88f67
- Move request_refund_payment to OffersMessageFlow a04753f
- Move pay_for_offer_human_readable to OffersMessageFlow e3784c8
- Move DNSResolverMessageHandler impl to OffersMessageFlow 546da37
- Move create_blinded_path_using_absolute_expiry to flow.rs 1868f99
- Introduce create_blinded_paths in flow.rs 1. This allow removing an extra function from commons, simplifying the ... 8ee9a71
- Move pending_offers_message to flows.rs c37e0f8
- Move pending_dns_onion_messages to flow.rs 2d6a15f
shaavan created a tag on shaavan/rust-lightning
pr3412.12 - A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
shaavan created a branch on shaavan/rust-lightning
omf-26 - A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
shaavan created a branch on shaavan/rust-lightning
omf-25 - A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
shaavan created a branch on shaavan/rust-lightning
omf-24 - A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
shaavan pushed 1 commit to main shaavan/code-chronicle
- Log 72: 20 Jan 2025 - Also fixed a typo in Log 71 6aa4437
shaavan created a comment on a pull request on lightningdevkit/rust-lightning
Updated from [pr3504.03](https://github.com/shaavan/rust-lightning/commits/pr3504.03) to [pr3504.04](https://github.com/shaavan/rust-lightning/commits/pr3504.04) ([diff](https://github.com/shaavan/...
shaavan pushed 67 commits to i3381a shaavan/rust-lightning
- Fix outdated static invoice docs. 43029bf
- Don't take() outbound invoice requests on retry Prior to this patch, we would take() the invoice request stored for ... 605cc3c
- Fix failure to abandon async payments on invalid static invoice Prior to this fix, we would attempt to mark outbound... 08d81fb
- Make create_blinded_payment_paths methods amount optional. Useful for creating payment paths for static invoices whi... e810075
- Factor invoice expiry into blinded path max_cltv_expiry Will be useful for static invoices' blinded paths, which may... 542deeb
- Add PaymentContext for async payments This context is stored in the blinded payment paths we put in static invoices ... 84f200f
- Add onion message AsyncPaymentsContext for inbound payments This context is included in static invoice's blinded mes... 96db8aa
- Add utils to create static invoices and their corresponding offers We can't use our regular offer creation util for ... 9898e67
- Test failures on paying static invoices Since adding support for creating static invoices from ChannelManager, it's ... 7d4af6a
- Move blinded keysend tests into new async_payments_tests.rs Blinded keysend is only planned to be supported in the a... d3a7efa
- Allow uppercase bech32 HRP Previously, we would fail parsing `Offer`s if the HRP didn't match our expected (lowercas... 540bcf7
- Add test coverage for upper-/mixed-case `Offer` encodings .. to ensure we're able to decode all-uppercase HRPs and r... 7d653c2
- Fix overly spammy `TRACE` logging in async onion message event handling We recently introduced `TRACE`-level logging... 1c0e463
- Merge pull request #3506 from tnull/2025-01-allow-upperase-hrp-main Allow uppercase bech32 HRP (main) 262d789
- Merge pull request #3508 from tnull/2025-01-fix-spammy-async-om-event-handling-logs-main Fix overly spammy `TRACE` l... 2c0066e
- Add debug implementations for scoring parameters Derives Debug for ProbabilisticScoringFeeParameters and Probabiliti... 48ceefd
- Combine InboundV2Channel and OutboundV2Channel Pending v2 channels will need to be broken up into separate phases fo... 91ff6c1
- Remove InteractivelyFunded trait Now that InboundV2Channel and OutboundV2Channel have been combined into a PendingV2... 270c5ab
- Combine UnfundedInboundV2 and UnfundedOutboundV2 Now that InboundV2Channel and OutboundV2Channel have been combined ... d6637d7
- Hide ChannelPhase::Funded behind as_funded method Exposing ChannelPhase in ChannelManager has led to verbose match s... 1780ce4
- and 47 more ...
shaavan created a tag on shaavan/rust-lightning
pr3504.04 - A highly modular Bitcoin Lightning library written in Rust. It's rust-lightning, not Rusty's Lightning!
shaavan created a comment on a pull request on lightningdevkit/rust-lightning
Updated from [pr3504.02](https://github.com/shaavan/rust-lightning/commits/pr3504.02) to [pr3504.03](https://github.com/shaavan/rust-lightning/commits/pr3504.03) ([diff](https://github.com/shaavan/...