Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Double checking, is a conversion factor needed?
samdev-7 created a review on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
~~Note that the arm is actually our intake, and the belt thing inside our robot (what's currently named as the intake) is the indexer. It would be good to make sure these terms align with the mecha...
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
This value should not be hard coded. It should be in the constants file as some "reduction" (don't name the variable "ratio" as it leaves ambiguity)
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Avoid hardcoding any values
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Can you make sure that the setpoint and actual measured position is logged through advantageKit. Use `Indexer/Setpoint/Velocity` and `Indexer/Measured/Velocity`
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Is this still needed. If not it should be deleted.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Is this still needed. If not it should be deleted.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Can you make sure that the setpoint and actual measured position is logged through advantageKit. Use `Intake/Setpoint/Position` and `Intake/Measured/Position` (and the velocity ones since manual co...
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Do not hard code can ids.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
It would be better to be very specific and have a method in the subsystem called `stopIntake()`. It would be very simple but would remove any possible confusion.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Again, perhaps use velocity as the word.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Per convention, add the "Cmd" to the name.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
The name can be a little more specific, perhaps `SetArmPositionPIDCmd`.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
The name can be a little more specific. Like `ArmManualSetSpeed`. Ideally, commands should be named as an action.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Can we try to stick to `velocity` as the keyword as it's what is used elsewhere?
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
This should not be commented out
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
What is this for?
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Please do not overwrite drivetrain code. It was probably impossible to test without the actual drivetrain, but the end goal is to have both.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
For consistancy ```suggestion public static final int kArmMotorCanId = 0; ```
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Can you make sure formatting on this file is set to `Spaces: 2` in VS Code (configured via the bottom information bar near the right)? It's been weird for me too.
samdev-7 created a review on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Note that the arm is actually our intake, and the belt thing inside our robot (what's currently named as the intake) is the indexer. It would be good to make sure these terms align with the mechani...
samdev-7 created a review on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Note that the arm is actually our intake, and the belt thing inside our robot (what's currently named as the intake) is the indexer. It would be good to make sure these terms align with the mechani...
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Also per convention, add the "Cmd" to the end of the command name
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
The drivetrain used `runVelocity` as the name as it matched most examples out there. Maybe that could be an option.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Are we using `speed` or `velocity` as the word? It'd be good to stick to one.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
No need to add shooter into the name here, since it's in the shooter class. It'll make it easier to find methods if they're all named the same thing inside of classes.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
What if the top and bottom shooters have different velocities? I don't think this is safe to assume.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Is this needed? If not, it should be removed.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Is this needed? If not, it should be removed.