Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
samdev-7 pushed 1 commit to master samdev-7/hassio-addons
- Allow the use of a basic auth string d90e141
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
```suggestion Logger.recordOutput("Gyro/Rotation", robotContainer.gyro.getRotation2d()); ```
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
What unit is this in?
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
What unit is this in, and this should be called `velocity`
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
You shouldn't need this. it's logged with AdvantageKit. (View with the AdvantageScope app and click "connect to robot") ```suggestion ```
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Can you make sure these are logged via AdvantageKit as `Launcher/Front/Setpoint/PercentVelocity` and `Launcher/Back/Setpoint/PercentVelocity`
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Can you make sure these are logged via AdvantageKit as `Launcher/Front/Setpoint/Velocity` and `Launcher/Back/Setpoint/Velocity`
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
```suggestion autonomousCommand = robotContainer.getAutonomousCommand(); ```
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Add a comment here with what the conversion factor is doing. Is this from rad/s to RPM? degrees per second?
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Can you make sure formatting on this file is set to `Spaces: 2` in VS Code (configured via the bottom information bar near the right)? It's been weird for me too.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
`onTrue` should only be used for commands that won't cause harm if it goes wrong. `whileTrue` would allow the operator to release the button in case of some fault (provided the `end` methods in the...
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
I think the subsystem should be abstracted to a point where folks using it don't have to care about the motors themselves (along with constants)—so yes to conversion factor. But, as long as the com...
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Being picky here, generally good to log setpoints before the setReference method is run. If the setReference method errors, the setpoint will still be logged. It makes it easier to isolate the error.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Does this not need PID for velocity control? What about the conversion factor? Velocity control is nice as percentage is dependent on battery voltage, which fluctuates.
samdev-7 created a review comment on a pull request on Earl-Of-March-FRC/2025-7476-Reefscape
Double checking, is a conversion factor needed?