Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sam-hey created a review comment on a pull request on embeddings-benchmark/mteb
Thx, I added a comment with extra information, clarifying that it is only PyLate that uses MaxSim.
sam-hey created a review comment on a pull request on embeddings-benchmark/mteb
This section is responsible for mapping the similarity function from `sentence_transformers` to enums when a model without a `ModelMeta` is provided.
sam-hey opened a pull request on embeddings-benchmark/mteb
feat: add enums for ModelMeta similarity_fn_name
ref: https://github.com/embeddings-benchmark/mteb/issues/1784 ref: add enum `ScoringFunction` for `similarity_fn_name` ### Code Quality <!-- Please do not delete this --> - [x] **Code For...
sam-hey pushed 5 commits to feat/enums sam-hey/mteb
- [v2] Refactor retrieval (#1750) * remove dres * refactor retrieval * fixes * fix tests * fix queries * remove d... ebca6bc
- [v2] remove `save_suffix` (#1924) remove save suffix 904f61c
- [v2] Remove multilingual task (#1926) * remove MultilingualTask * remove MultilingualTask * rename lang to hf_subs... a619ad8
- [v2] Merge main (#1927) * Update tasks table * Update tasks table * Update tasks table * Update tasks table * Up... 3d1f80c
- Merge remote-tracking branch 'mteb/v2.0.0' into feat/enums 7f3962a
sam-hey created a comment on a pull request on embeddings-benchmark/results
@KennethEnevoldsen A bit short on time this month, but I'll take a look next month
sam-hey created a comment on an issue on embeddings-benchmark/mteb
This commit can be used as ref: https://github.com/embeddings-benchmark/mteb/commit/5a023d6f661932f6bf92c4b3b435b0c128138f75 It should include all necessary changes to use `Enums` for `similarity_...
sam-hey created a comment on a pull request on lightonai/pylate
I added them as a review, thinking you would be able to see them, but it seems they are in a pending state, so that’s not the case. I also added a comment, which should be visible to you. > You al...
sam-hey created a comment on a pull request on lightonai/pylate
It seems that my comments are in Pending state, so they can't be seen at the moment. I have just one small regrade: I wouldn’t categorize this as a warning, as it’s expected behavior. It’s merel...
sam-hey created a comment on a pull request on lightonai/pylate
A huge thank you from my side! I did add two comments, but they're just small nitpicks :) Otherwise, I tested it locally, and it looks good to me. Thanks a lot for the effort! So just the Ruff v...
sam-hey created a comment on a pull request on lightonai/pylate
I want to highlight this for two main reasons: First, I encountered an issue with the configuration not being loaded properly, and second, I wasn’t sure what exactly was being loaded that could be ...
sam-hey created a comment on a pull request on lightonai/pylate
I applied your feedback to make the warning message more precise and also fixed some documentation.
sam-hey created a comment on an issue on embeddings-benchmark/mteb
Thanks a lot for your effort so far! I would probably go with setting all non-valid operations to None or NaN, as this clearly indicates the absence of a valid value. However, let's see what @orion...
sam-hey created a comment on an issue on embeddings-benchmark/mteb
Ok, thanks a lot for your feedback! I will take a look at it!
sam-hey created a comment on an issue on embeddings-benchmark/mteb
I'm not sure if I'm missing something, but in my opinion, it should be possible to simply inherit from one of the Adapter classes in the `ModelWrapper` (SentenceTransformerWrapper etc.) class. This...
sam-hey created a comment on an issue on embeddings-benchmark/mteb
I would like to propose an improvement to MTEB by introducing an Adapter Class between Model Classes and Tasks. Currently, the logic in [RetrievalEvaluator](https://github.com/embeddings-benchmark/...
sam-hey created a comment on an issue on embeddings-benchmark/mteb
Hello @imadtyx, Thanks a lot for working on this! As @Samoed pointed out, it's not possible to achieve this by simply searching for the text. I suggest reducing the scope of the PR to first just...
sam-hey created a comment on an issue on lightonai/pylate
Yes, this is exactly what I mean. No problem, I totally understand the time aspect—just knowing that it will come eventually is reassuring. My experiments showed a small difference, but it wasn’t ...
sam-hey opened a pull request on lightonai/pylate
ref: ruff python 3.8 & update warning
Align Ruff with setup.py: Set Python version to **3.8** for Ruff to ensure consistency with `setup.py` https://github.com/lightonai/pylate/blob/c6a22fcdc313ee1c2ced454f77bd4c199cb964b4/setup.py...