Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
saeliddp created a comment on a pull request on AllenInstitute/biofile-finder
Nit: the expiration/eviction period is currently 182 days, not 180. We can change this on the backend if desired. Could also say '6 months' on the frontend, or maybe it's not an important distincti...
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
It seems like by switching to `**kwargs`, we are thinning the separation between our `Viewer` interface and `napari.Viewer`. I think if this is the route we're going down, we should at minimum note...
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
I'm still struggling to understand `Source` 1. Why is source inheriting from `SegmenterLayer`--Source is not a Layer right? It's an attribute of a layer 2. Do we actually need to mimic the fact t...
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Where do we use the 'source' attribute in the code?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Is the reason we apply thresh function again is because it's possible that they've selected a folder to threshold and the thresholded images aren't already in the viewer?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Does this get around the issue w/ lambda functions?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Why are there training changes in this PR?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
We don't need to deal with channels because segmentations are already single channel, right? Is there any harm in just having the channel selection option there but with only one option?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
^^ that idea sounds good to me, if it's not too tricky to implement widget inheritance
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Should this only get fired when `enable` is true?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
This name is a bit misleading--this is only used for thresholds, not the initial segmentations, right? Maybe better to call it `_thresholds_inserted` or something
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
The meaning of 'source' is not clear to me from this file alone. Comments would be helpful. And what is the purpose of the kwarg 'name'?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Maybe handle the case where there is no layer with `layer_name`?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Kinda frustrating that napari's viewer doesn't support inserting as a method on the viewer