Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
so, `seg_layers` is a flag for whether to remove corresponding segmentation layers after thresholding? Maybe rename to `remove_seg_layers`?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Appears that `layer_list` parameter is unused in the implementation -> prob fine to get rid of it in the `i_viewer` and implementations
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Description for `seg_layers` param?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Thanks for adding comments! Still not sure on one point: Why does this need to take `layer_list` as a param? Shouldn't the viewer already have access to the layer list and apply a filter on that li...
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
This comment applies to all of the new tests in this file--am I missing something?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
I would expect the test to work just as well if you deleted lines 109-114?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Not sure I understand why we are using a fake subscriber for the max channels set event in this test
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
I don't think we want the `.` added back in; iirc, PyPI only recognizes RC versions without the `.`
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
The parameters for this and the function below are not self-explanatory to me--a comment would be useful
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Good idea to make this a constant
saeliddp created a comment on a pull request on AllenInstitute/biofile-finder
> This also doesn't contain any notification content to the user about success/failure (apart from invalid submissions) and the response is unused. We need to think about what we want to return to ...
saeliddp created a review on a pull request on AllenCell/allencell-segmenter-ml
<img width="1680" alt="Screenshot 2024-11-18 at 2 26 14 PM" src="https://github.com/user-attachments/assets/a7b9fdae-5d71-4354-843e-e72f76f5e768"> Have you looked into this?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Why are we adding this dependency?