Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Looks like that happens here: [in the overrides manager class](https://github.com/AllenCell/allencell-segmenter-ml/blob/5676077d5f81e3c519e18bcea9bdf5c98dfd8938/src/allencell_ml_segmenter/utils/cyt...
saeliddp created a review on a pull request on AllenInstitute/biofile-finder
Thanks for working on this! Left a few comments related to users only being allowed to move files onto the cache
saeliddp created a review comment on a pull request on AllenInstitute/biofile-finder
Do we need the `Move Files` item and the sub-menu `Cache Location` now that there is only one `Cache Location` option? There could just be a top-level `Move files to cache` item instead.
saeliddp created a review comment on a pull request on AllenInstitute/biofile-finder
This language should be updated (just getting rid of 'to or') also line 155
saeliddp created a review comment on a pull request on AllenInstitute/biofile-finder
Seems like we no longer need this logic after the UI change to restrict to only moving on to cache
saeliddp created a comment on a pull request on AllenInstitute/biofile-finder
**General comment**: After a few rounds of discussion, we decided that we should _not_ give BFF users the ability to move files off of the cache. Instead, once a file is moved onto the cache, it...
saeliddp created a review on a pull request on AllenCell/allencell-segmenter-ml
Have some questions/suggestions, but overall looks good!
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Why does this say global stylesheet? Shouldn't it only apply to thresholding?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
this should be a `PredictionModel` always, right? If so, I think it's better to be specific in the type annotation
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
IIRC we removed it from the prediction view but kept the code around so that we could have a starting point for thresholding in the future
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
What do you think about using model composition instead of inheritance? To me it seems less like `PredictionModel` is a `FileInputModel` and more like `PredictionModel` has a `FileInputModel` becau...
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
It seems like `...PREDICTION...` events should not be dispatched from a model that is not specific to prediction
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Thoughts on converting from home-baked events to slots/signals?
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
Applies to comments throughout this file
saeliddp created a review comment on a pull request on AllenCell/allencell-segmenter-ml
nit: if you're getting rid of assertions on postproc method, this reference to postprocessing method in the comment might be confusing