riccioc created a comment on an issue on gundam-organization/gundam
The group discussed at the development meeting on Sept. 19, 2025 and agreed to suggest to keep using `TClonesArray`. We will close this issue if we don't hear objections in the next two weeks.
riccioc closed a pull request on GUNDAM-DUNE-Inputs/gudi-anoa-sen25a
Feature/oscillation parameter covariance
Adds a covariance matrix definition for the oscillation parameter set. Three baseline covariances are provided (normal mass hierarchy, inverted mass hierarchy, and an "averaged" mass hierarchy tha...
riccioc created a review on a pull request on gundam-organization/gundam
This is very minor and I approve it. I have only a general comment: it sounds odd that for `parameterName` we moved to `name`, while for `paramterIndex`, `parameterLimits` etc. we keep `parameter`....
riccioc pushed 5 commits to main gundam-organization/gundam
- Add yaml to set the cyclic range for a parameter The cyclicRange key for the parameter is mostly for documentation, ... 17cdfd6
- Fix stupid mistake in gundamPlotMCMC.C Wanted "not std::isfinite(val)", but had "std::isfinite(val)". 6fb1d8e
- Import TSimpleMCMC supporting cyclic parameters 0a1a93d
- Set cyclic domain in SimpleMcmc Tell TSimpleMCMC that a parameter is cyclic when the "cyclicRange" key is used. 99e82db
- Merge pull request #869 from gundam-organization/feature/CyclicParameters Feature/cyclic parameters f591f9b
riccioc closed a pull request on gundam-organization/gundam
Feature/cyclic parameters
Handle cyclic parameters. This is contingent on #868. Adds `cyclicRange` to the Parameter yaml which lets the user set a range for a cyclic parameter. For minimization this is a NOP since it w...
riccioc pushed 5 commits to main gundam-organization/gundam
- Add method to access full covariance matrix For efficiency the prior covariance matrix strips out all of the fixed a... e1e614b
- Fix handling of parameter covariances This updates to the new stripped covariance matrices. I also removed an inappr... 0e2d9af
- Add a bit more debugging Useful diagnostics for looking at SimpleMcmc outputs. This exposes error reports when odd ... 0333fa3
- Cleanup SimpleMcmc error output Change a some throws to use LogExit so the batch output is properly shown. Add some... 5799578
- Merge pull request #868 from gundam-organization/fix/SimpleMCMCCovariance Fix: SimpleMcmc correlations with a stripp... 4c25bb3
riccioc closed a pull request on gundam-organization/gundam
Fix: SimpleMcmc correlations with a stripped covariance
The SimpleMcmc was not handling the new way of using covariances correctly. It now uses the full parameter set covariance so that it can refer to the raw parameter inside the set, independent of ...
riccioc created a comment on an issue on gundam-organization/gundam
Implementation in [feature/profiling](https://github.com/gundam-organization/gundam/compare/feature/profiling)
riccioc closed an issue on gundam-organization/gundam
MinimizerBase and SimpleMcmc bounds handling broken by refactor
The refactored MinimizerBase changed how it's handling parameter bounding, but doesn't implement all of the functionality needed by the MCMC. The same refactoring didn't finish the necessary chang...
riccioc pushed 3 commits to main gundam-organization/gundam
- Add user interface to parameter validity The Parameter class changed to incorporate ranges, but the user interface d... e3e2f98
- Finish migration to refactored Parameter This now leverages the MinimizerBase interface 0f358b3
- Merge pull request #866 from gundam-organization/fix863/ParameterLimitInterface Fix863/parameter limit interface 49b6567
riccioc closed a pull request on gundam-organization/gundam
Fix863/parameter limit interface
Fix Issue 863: Finish the refactoring of parameter validity ranges.
riccioc pushed 2 commits to main gundam-organization/gundam
riccioc closed a pull request on gundam-organization/gundam
[Nano] Exposing `setDoAllParamVariations` to the python interface
riccioc closed a pull request on gundam-organization/gundam
Reset SimpleMcmc proposal before first step
Make sure that the users requested proposal covariance is correctly used for the initial steps of a chain.
riccioc closed a pull request on GUNDAM-DUNE-Inputs/gudi-anoa-sen25a
Add updated version of GOAT
The gundamOscAnaTools v1.1.0 had some debugging statements commited that are removed in v1.1.1.
riccioc closed an issue on gundam-organization/gundam
Add timer for the dial updates
The dial updates can be rather time consuming when tables need to be filled. For now, this is only being included in the overall propagator iteration speed, but should be timed like the reweightin...
riccioc created a comment on an issue on gundam-organization/gundam
If #802 is working, then this can be closed.
riccioc created a comment on an issue on gundam-organization/gundam
Thanks! Adrien is working on #837 and as soon as the work there it is finished this will be reviewed.
riccioc closed an issue on gundam-organization/gundam
Sandbox application broken and not needed for ENABLE_DEV_MODE
Title says it all! The Sandbox is only needed for special purpose testing, and isn't kept up-to-date. It should be behind its own "special" definition. I'd suggest requiring `-DWITH_SANDBOX_APP=...
riccioc pushed 3 commits to main gundam-organization/gundam
riccioc closed a pull request on gundam-organization/gundam
Fix/Add explicit sandbox enable
The Sandbox application is for specific debugging, and isn't generally needed (even in developer mode). Those needing SandBox _know_ what they are doing, so can turn it on explicitly since it ofte...
riccioc closed an issue on gundam-organization/gundam
Kriging fails when weights are not applied to all events of a sample
For the usual case, there is one kriged dial per event in a sample. When there the number of dials is less than the number of events, an error trap is incorrectly triggered.
riccioc closed a pull request on gundam-organization/gundam
Fix/weight krigged
Closes #850. Critical fix. Fix a critical bug stopping the DUNE anoa analysis. The problem originally manifest as a host to device (device synchronization) problem, but was fundamentally due t...
riccioc created a comment on an issue on gundam-organization/gundam
If we don't know what the difference is between WARNING and ALERT, should we just use WARNING?