Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pgarrison closed a pull request on AllenInstitute/biofile-finder
Remove react dev tools for electron
# Purpose I couldn't run the development version of BFF desktop on my machine (#364). Closes #364 # Changes Remove React Dev Tools entirely from the electron development build. # Testin...
pgarrison created a comment on a pull request on AllenInstitute/biofile-finder
Thanks @aswallace for helping with `jszip`!
pgarrison opened a draft pull request on AllenInstitute/biofile-finder
368: Use Local File Path annotation
pgarrison created a branch on AllenInstitute/biofile-finder
feature/368-use-local-file-path-annotation - An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.
pgarrison created a comment on a pull request on AllenInstitute/biofile-finder
I suggest not using "Cache" or "lease". Perhaps the following instead: Copy Files to Local NAS (Vast) Files copied to the local NAS (Vast) are stored with a 180-day expiration, after which th...
pgarrison pushed 1 commit to bugfix/local-desktop-dev AllenInstitute/biofile-finder
- Install jszip 5d7472b
pgarrison created a comment on an issue on AllenInstitute/biofile-finder
I plan to remove and replace this test as part of #368
pgarrison opened an issue on AllenInstitute/biofile-finder
FileAnnotationList test asserts nothing and would fail if it did assert
# 1. The test asserts nothing The following test does not actually assert anything: `<FileAnnotationList /> file path representation has both canonical file path and file path adjusted to OS & all...
pgarrison pushed 2 commits to main AllenInstitute/biofile-finder
pgarrison opened an issue on AllenInstitute/biofile-finder
Use "Local File Path" annotation for the local path with the user's host mount
With the cloud-first FMS backend changes, BFF now renders local paths like this: ``` Local File Path /allen/aics/software/apps/staging/fss/data/7fb/6fb/b0f/6bd/7d5/1db/a4c/1e4/2a6/2a5/c7/aicsfile...
pgarrison opened an issue on AllenInstitute/biofile-finder
Use Cloud path, not Canonical path, for FMS datasource
With the latest FSS changes, `file_path` gets rendered like this: ``` File Path (Canonical) staging.files.allencell.org/130/b23/bfe/117/2a4/71b/746/002/064/db4/1a/danny_int_test_4.txt ``` But i...
pgarrison opened an issue on AllenInstitute/biofile-finder
Hide "Should Be In Local Cache" annotation
This annotation is an implementation detail of FMS, not needed by end users. With the upcoming metadata editing feature, this is not an annotation end users should be able to edit.
pgarrison created a comment on an issue on AllenInstitute/biofile-finder
More design decisions needed: The plan above uses "File Path (Canonical)" but does not account for "File Path (Local)", since our test usage of BFF didn't surface files with a "File Path (Local)". ...
pgarrison opened a pull request on AllenInstitute/biofile-finder
Remove react dev tools for electron
# Purpose I couldn't run the development version of BFF desktop on my machine (#364). Closes #364 # Changes Remove React Dev Tools entirely from the electron development build. # Testin...
pgarrison pushed 1 commit to bugfix/local-desktop-dev AllenInstitute/biofile-finder
- npm remove electron-devtools-installer @types/electron-devtools-installer dbf2758
pgarrison created a branch on AllenInstitute/biofile-finder
bugfix/local-desktop-dev - An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.
pgarrison created a comment on an issue on AllenInstitute/biofile-finder
I removed React Dev Tools and that resolved it!
pgarrison opened an issue on AllenInstitute/biofile-finder
Cannot start BFF desktop in development environment (MacOS)
# Steps to reproduce * `git clone ...` * `npm ci` * `npm --prefix packages/desktop run start` * Expected output: An electron window opens with BFF * Actual output: An electron process star...
pgarrison opened an issue on AllenInstitute/biofile-finder
Zarrita causes type checker errors
# Steps to reproduce * `npm run typeCheck`, per the docs * Expected output: no errors * Actual output: `Found 21 errors in the same file, starting at: node_modules/@zarrita/core/dist/src/hierarc...
pgarrison opened a pull request on AllenInstitute/biofile-finder
gitignore mise configuration
I'm using [mise](https://mise.jdx.dev/) to manage my dev environment. Judging from the `.gitignore` I'm the only one, so we can leave mise's config file out of the repo. In case anyone is curiou...
pgarrison created a branch on AllenInstitute/biofile-finder
feature/mise-gitignore - An open-use web application created for easy access, collaboration, and sharing of datasets through rich metadata search, filter, sort, and direct viewing in common industry applications or in our web-based 3D Volume Viewer.
pgarrison created a review comment on a pull request on AllenInstitute/biofile-finder
Great! I didn't open BFF, just tested against a generic `<input type="number" />` element
pgarrison created a review comment on a pull request on AllenInstitute/biofile-finder
From playing with [this example](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/number) input, it seems that `min`and `max` control what the increment/decrement buttons do, but not...
pgarrison created a review comment on a pull request on AllenInstitute/biofile-finder
I think these `max` values are inclusive? In which case these bounds (here and below) should be 23 and 59
pgarrison created a review comment on a pull request on AllenInstitute/biofile-finder
Maybe something like `matches` is more clear than `exec`?
pgarrison created a review comment on a pull request on AllenInstitute/biofile-finder
Leave a comment about why the `!important` is necessary?
pgarrison created a review on a pull request on AllenInstitute/biofile-finder
This UI looks so nice!