Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
petrykivd created a review comment on a pull request on mate-academy/py-game-models
What happens if race_dicts has no skills? 😄
petrykivd created a review comment on a pull request on mate-academy/py-movie-moviesession-cinemahall
Agree with AI mentor
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
I think you can simplify it to list of strings 😄
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
You can avoid unnecessary variables and return the filtered actor at once
petrykivd created a review on a pull request on mate-academy/py-genres-and-actors
Great job! 👍 Fix a small problem please 😄
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
It doesn't look very readable, try to improve the code style
petrykivd created a review on a pull request on mate-academy/py-genres-and-actors
Great job! 👍 Fix a small problem please 😄
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
Should this be commented on?
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
It's better to follow SQL style guidelines even while writing raw SQL in Python. Therefore I'd suggest to start FROM clause from new line.
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
Fix it in all places
petrykivd created a review on a pull request on mate-academy/py-actor-manager
Nice! 😎 I recommend trying to fix the raw SQL 👌
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
It's must work good
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
def all(self) -> list[Actor]: actors_cursor = self._connection.execute( f"SELECT * " f"FROM {self.table_name}" ) return [Actor(*row) for row in ...
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
Please read the checklist before submitting your solution. In the 3rd paragraph, it says about DRY ( Don't Repeat Yorself). Use loop for creating genres and actors
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
Adding migrations to a .gitignore is a bad practice. How are these migrations supposed to be used by other developers when they run the project locally? This is also indicated in the checklist!