Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
petrykivd created a review comment on a pull request on mate-academy/py-split-integer
FIx it in all places
petrykivd created a review comment on a pull request on mate-academy/py-split-integer
Please read checklist before pushing your solution! Don't create unnecessary variables for simple tests:
petrykivd created a review comment on a pull request on mate-academy/py-split-integer
Are you sure you need to use parameterization here?
petrykivd created a review comment on a pull request on mate-academy/py-copy-file
Simplify and combine two conditions into one. if source == target or command != "cp": return
petrykivd created a review comment on a pull request on mate-academy/py-copy-file
You can simplify the unpacking in next way: command, source, target= command.split()
petrykivd created a review comment on a pull request on mate-academy/py-copy-file
Maybe command is better naming for this variable? cp is just a part of command
petrykivd created a review comment on a pull request on mate-academy/py-copy-file
You can simplify the unpacking in the way Valentyn wrote to you earlier. command, source, destination = command.split()
petrykivd created a review comment on a pull request on mate-academy/py-copy-file
Simplify and combine two conditions into one. if source == destination or command != "cp": return
petrykivd created a review comment on a pull request on mate-academy/py-copy-file
You can use 1 if for return: if source_file == destination_file or command != "cp": return
petrykivd created a review comment on a pull request on mate-academy/py-copy-file
You can simplify the unpacking in the way Valentyn wrote to you earlier. command, source, destination = command.split()
petrykivd created a review comment on a pull request on mate-academy/py-lockdown-cafe
Don't duplicate this string here and in cafe class. You can return here text of error. (as e)
petrykivd created a review comment on a pull request on mate-academy/py-lockdown-cafe
Agree with Yelizaveta
petrykivd created a review comment on a pull request on mate-academy/py-lockdown-cafe
You must except here "Vaccine Error". NotVaccinatedError, OutdatedVaccineError Inherited from VaccineError.
petrykivd created a review comment on a pull request on mate-academy/py-cache-decorator
wrapper return None in all cases?
petrykivd created a review comment on a pull request on mate-academy/py-lockdown-cafe
if visitor["vaccine"].get("expiration_date") < date.today():
petrykivd created a review comment on a pull request on mate-academy/py-lockdown-cafe
if expiration_date < date.today()
petrykivd created a review comment on a pull request on mate-academy/py-lockdown-cafe
"Visitor is not wearing a mask." 2 spaces between visitor and is, remove 1 "Visitor is not wearing a mask."
petrykivd created a review on a pull request on mate-academy/py-lockdown-cafe
Approved, but please fix the remaining comments.
petrykivd created a review on a pull request on mate-academy/py-lockdown-cafe
Approved, but please fix the remaining comments.
petrykivd created a review comment on a pull request on mate-academy/py-lockdown-cafe
There should be an empty line between the imports of default libraries and custom files.
petrykivd created a review comment on a pull request on mate-academy/py-lockdown-cafe
Why do you need an extra list? Isn't just counter enough?