Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
petrykivd created a review comment on a pull request on mate-academy/py-taxi-service-home-page
{% block sidebar %} {% include "includes/sidebar.html" %} {% endblock %} {% block content %} {% endblock %} Clearly delineate blocks so you can see where everything is
petrykivd created a review comment on a pull request on mate-academy/py-taxi-service-home-page
Title also can be additional block, title can be changed in specific url.
petrykivd created a review comment on a pull request on mate-academy/py-taxi-service-home-page
Add indentation inside blocks, fix it in all places
petrykivd created a review on a pull request on mate-academy/py-movie-moviesession-cinemahall
Well done! 🚀
petrykivd created a review comment on a pull request on mate-academy/py-movie-moviesession-cinemahall
If you want to use .distinct(), maybe it's better to use it once at the end?
petrykivd created a review comment on a pull request on mate-academy/py-movie-moviesession-cinemahall
Maybe it's better to return string?
petrykivd created a review comment on a pull request on mate-academy/py-movie-moviesession-cinemahall
Simplify it
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
class Meta shoukd be placed after attributes and before methods.
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
We don't capitalize common variables. User must be constant ( USER ) or user.
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
class Meta should be placed after attributes and before methods. Don't forget to read checklist, please Fix it everywhere
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
Fix codestyle
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
movie_session_id is MovieSession? Or it is int? 😄
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
Are you sure that in the context of a transaction, creating an order should skip sessions that do not exist? Then this order will not be complete. In this case, it will be normal if the transactio...
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
Fix in other places too
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
Same here about is not None
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
You can avoid additional movie_session_to_delete variable, MovieSession.objects.get(id=session_id).delete()
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
class Meta should be placed after all attributes and before methods.
petrykivd created a review comment on a pull request on mate-academy/py-tickets-and-orders
if title is the same as if title is not None 😄
petrykivd created a review comment on a pull request on mate-academy/py-movie-moviesession-cinemahall
Stick to the same code style, if you specify list[int] below, you should also specify it here