Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
def all(self) -> list[Actor]: actors_cursor = self._connection.execute( f"SELECT * " f"FROM {self.table_name}" ) return [Actor(*row) for row in ...
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
Please read the checklist before submitting your solution. In the 3rd paragraph, it says about DRY ( Don't Repeat Yorself). Use loop for creating genres and actors
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
Adding migrations to a .gitignore is a bad practice. How are these migrations supposed to be used by other developers when they run the project locally? This is also indicated in the checklist!
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
If the methods can be written in one line, it is better not to split it into new lines. Check it and fix in another places
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
Remove all prints
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
for genre in genres
petrykivd created a review comment on a pull request on mate-academy/py-genres-and-actors
Better to name it "genres"
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
It's better to follow SQL style guidelines even while writing raw SQL in Python. Therefore I'd suggest to start FROM clause from new line. Also fix it in all places
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
It's better to follow SQL style guidelines even while writing raw SQL in Python. Therefore I'd suggest to start FROM clause from new line. Fix it in all places too
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
Maybe it's better to use actor_id instead of _id? And why do you need underscores for last_name and first_name? Are these protected parameters? 😮
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
Instead of creating a new connection in each etode, you can create one in the class initial and use it for .execute(). Much less code
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
Fix the order of imports
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
Maybe it's better to use actor_id than id_?
petrykivd created a review comment on a pull request on mate-academy/py-actor-manager
It's better to follow SQL style guidelines even while writing raw SQL in Python. Therefore I'd suggest to start FROM clause from new line. In other places too