Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
nguerrera created a comment on a pull request on microsoft/cask
OK, I've simplified to reduce bug risk, and measured to ensure that the things I simplified weren't worth it. See updated comment with benchmarks.
nguerrera created a comment on a pull request on microsoft/cask
I dreamt of a bug and now I'm inclined to revert the polyfills to simpler code. Fixed in https://github.com/microsoft/cask/pull/18/commits/2e176bdf9334dcb0d842316cdcd6b07c897b9e41 But I also ...
nguerrera pushed 1 commit to benchmark nguerrera/cask
- Fix polyfill bug with exact key size equal to block size 2e176bd
nguerrera created a review comment on a pull request on microsoft/cask
Leaving this since it's unchanged here, a known thing we need to address that's discussed in Questions.md and we discussed how to change the format offline to fix this. In the new year, I will do t...
nguerrera created a review comment on a pull request on microsoft/cask
Since this is unchanged code, I'm leaving this and we can discuss it separately.
nguerrera created a review comment on a pull request on microsoft/cask
This branch is taken before anything else is compared. I am guilty of just trying to hit the block in code coverage. I'm just going to delete this test for now.
nguerrera created a review comment on a pull request on microsoft/cask
I thought about that, but this change is getting big and I only changed this as much as was useful to get through what I was doing. It's a good idea! There's also some ways to tell BenchmarkDotNet ...
nguerrera created a review comment on a pull request on microsoft/cask
I'm not sure I follow everything here. This API is exactly the reason why I want the key to record how much entropy it has. It's really weird to pass (key, entropy), but it's impossible to get the ...
nguerrera created a review comment on a pull request on microsoft/cask
I wasn't sure about this, but all the examples I saw had tiny amounts of data and it will be the only place where we cannot stackalloc unconditionally. But I'll remove this limitation.