Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
nguerrera pushed 5 commits to c3id nguerrera/cask
- Do not try to run net472 tests on non-Windows using Mono (#22) The PR validation builds started failing when Mono wa... 6eb0619
- Add initial README content (#25) Also remove TODOs from SUPPORT.md 5e9a134
- Add standard BNF for 256-bit primary key. (#26) This change adds a spare markdown standard BNF specification for CAS... 01ac458
- Merge branch 'main' into c3id 35e69e5
- Fix build after merge 4e56028
nguerrera pushed 3 commits to main nguerrera/cask
- Do not try to run net472 tests on non-Windows using Mono (#22) The PR validation builds started failing when Mono wa... 6eb0619
- Add initial README content (#25) Also remove TODOs from SUPPORT.md 5e9a134
- Add standard BNF for 256-bit primary key. (#26) This change adds a spare markdown standard BNF specification for CAS... 01ac458
nguerrera created a review comment on a pull request on microsoft/cask
With that said, I think it would be good to take this change and discuss options to improve this in follow-up.
nguerrera created a review comment on a pull request on microsoft/cask
## Without C3ID in hash scenarios From https://github.com/microsoft/cask/pull/18#issuecomment-2555778281 | Method | Mean | Error | StdDev | Gen0 | Allocated | |-----...
nguerrera created a review comment on a pull request on microsoft/cask
I'm getting concerned about the cost here. Two rounds of SHA256 is a lot of compute for a 12 byte hash. For context from offline conversation: the rationale (as I understand it, but I may not) ...
nguerrera created a review comment on a pull request on microsoft/cask
I went with `C3Id` now. I need it in non-test code in my next change. Still not public, but I think it's worth settling this right now and not having noise of renaming it mixed in with other change...
nguerrera created a review comment on a pull request on microsoft/cask
We decided offline to revert back to what I had in the end.
nguerrera pushed 9 commits to format-update nguerrera/cask
- Update to new proposed C3ID standard, respond to PR feedback 769b694
- Tweak to reference implementation to make it prettier 4cbd826
- fixup HashData -> byte[] polyfill 0cdb16e
- Avoid aka, and just use acronym after introduction in class Summary a600b8b
- PR feedback - Use base64-decoded prefix for hash input and base64-encode input - Throw on empty or whitespace 611d90b
- Update src/Tests/Cask.Tests/CrossCompanyCorrelatingIdTests.cs cfb68a7
- Phone call feedback. Re-simplify. 0591c45
- Additional test 46b9bdb
- WIP c8bf29d
nguerrera created a review comment on a pull request on microsoft/cask
This is still missing things after timestamp. Also, the indices look off `^15..^12` is both part of the provider signature and the timestamp.
nguerrera pushed 1 commit to c3id nguerrera/cask
- Update src/Tests/Cask.Tests/CrossCompanyCorrelatingIdTests.cs cfb68a7
nguerrera created a review comment on a pull request on microsoft/cask
```suggestion /// A trivial reference implementation of C3ID that is easy to understand, ```
nguerrera created a review comment on a pull request on microsoft/cask
```suggestion |decodedKey[^9..^6]||||Time stamp data encoded in 4 six-bit blocks for YMDH. ```
nguerrera created a review comment on a pull request on microsoft/cask
```suggestion |decodedKey[..^4]|0 - 255|0x0..0xFF|00000000b..11111111b|CRC32(key[..^4]) ```
nguerrera created a review comment on a pull request on microsoft/cask
I'd prefer not to have "this data can be repurposed" in the spec.
nguerrera created a review comment on a pull request on microsoft/cask
`Reserved` should usually be avoided in enums. Is this API meant to stay internal? We might consider putting these masks in separate constants if the enums will be made public.