Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
nguerrera created a review comment on a pull request on microsoft/cask
This is called provider `providerSignature` in the API, should we change that to `providerId` or this to `provider-signature`?
nguerrera created a review comment on a pull request on microsoft/cask
Avoid properties that allocate on every call. I suggest `string Encode()` method. The core API shouldn't use this and only allocate a single, complete key/hash string at the very end. If it's not a...
nguerrera created a review comment on a pull request on microsoft/cask
We had said we'd fill the padding byte with random, I think, on our last call. I am just curious, did you change your mind?
nguerrera created a review comment on a pull request on microsoft/cask
The backing storage here could be `int` so that the data is inlined into the struct and this bit twiddling can be done without heap allocation.
nguerrera created a review comment on a pull request on microsoft/cask
```suggestion /// Message Authentication Code of a derivation input generated by SHA-384 ```
nguerrera created a review comment on a pull request on microsoft/cask
Avoid referring to HMAC 'instance'. I think this is an implementation detail of legacy .NET crypto API.
nguerrera created a review comment on a pull request on microsoft/cask
```suggestion /// Message Authentication Code of a derivation input generated by SHA-256 ```
nguerrera pushed 1 commit to c3id nguerrera/cask
- PR feedback - Use base64-decoded prefix for hash input and base64-encode input - Throw on empty or whitespace 611d90b
nguerrera pushed 1 commit to c3id nguerrera/cask
- PR feedback - Use base64-decoded prefix for hash input and base64-encode input - Throw on empty or whitespace 7550caf
nguerrera created a review comment on a pull request on microsoft/cask
I'll go ahead and use the decoded prefix in both places.
nguerrera created a review comment on a pull request on microsoft/cask
Since this is not going to catch all bad input, I am going to compromise and only find ASCII-range whitespace.
nguerrera created a review comment on a pull request on microsoft/cask
> I note this arguably creates more call site complexity. I agree and I think this isn't worth it. There should be an articulated reason other than lining up with span alternatives to have an ou...
nguerrera created a review comment on a pull request on microsoft/cask
Actually, it isn't so magic anymore with collection expressions and no `new byte[]` that doesn't actually allocate an array. Collection expressions are documented to optimize: https://learn....
nguerrera created a review comment on a pull request on microsoft/cask
I went to do it and the most annoying thing is validating whitespace on the UTF-8 overload. I thought we might want this to be public since I could imagine something processing a ton of UTF-8 data ...
nguerrera created a review comment on a pull request on microsoft/cask
Will do. Incidentally, completely separate, but you may wonder why this span return is OK. It looks like it allocates a new array on every property call, after all! It turns out that this partic...
nguerrera pushed 1 commit to c3id nguerrera/cask
- Avoid aka, and just use acronym after introduction in class Summary a600b8b
nguerrera created a review comment on a pull request on microsoft/cask
> Wait, aren't we supposed to be using the PrefixBase64Decoded const bytes here? I misunderstood if that's what you wanted. However, it does seem valuable to me that I can specify C3ID and write...