Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
nguerrera pushed 1 commit to main microsoft/cask
- Initial skeleton code for C++ Implementation (#16) * Add libcask native dll project to solution * Add stub implement... d63a335
nguerrera closed a pull request on microsoft/cask
Initial skeleton code for C++ Implementation
* Add libcask native dll project to solution * Add stub implementation aligned to test ICask interface * Add P/Invoke interop in tests * Use MSBuild and Xunit magic so that we 1. Have a good ...
nguerrera created a review comment on a pull request on microsoft/security-utilities
Keep in mind that I am a newbie when it comes to regexes, but I wonder if we could have some central repository of secret regexes that allows for different flavors of regexes for the same purpose t...
nguerrera created a comment on a pull request on microsoft/cask
> please get a sign off from someone with production C++ experience (which does not include me)! @michaelcfanning OK to merge?
nguerrera created a review comment on a pull request on microsoft/cask
Yes, good point. We probably want to reserve a place for error codes across the board and consistently. And we probably want this irrespective of whether or not they are needed by the initial imple...
nguerrera created a comment on a pull request on microsoft/cask
@KalleOlaviNiemitalo Docs will come very soon. That said, this project is just getting off the ground and you may continue to see things hit the repo out of natural order.
nguerrera created a review comment on a pull request on microsoft/cask
Yes. This is on my radar! I will make x-plat great, I promise.
nguerrera created a review comment on a pull request on microsoft/cask
I've said that if I had a time machine, I'd prevent the invention of more than one line-ending scheme. I'd also prevent a second slash direction and the concept of capital letters. :)
nguerrera created a review comment on a pull request on microsoft/cask
Free as in there's nothing technically stopping it from working. Depending how carried away the C++ gets, there could be perf or other costs.
nguerrera pushed 1 commit to cpp nguerrera/cask
- Apply suggestions from code review Co-authored-by: Ross Wollman <[email protected]> 135c081
nguerrera created a review comment on a pull request on microsoft/cask
This test wrapper isn't a good benchmark, it is not even trying to be fast. The cross-language interface still used arrays and such. It is conceivable that a non-trivial amount of effort could p...
nguerrera created a review comment on a pull request on microsoft/cask
I don't think there's any chance that the interop will win.
nguerrera created a review comment on a pull request on microsoft/cask
I think Michael means we use std:string internally and copy from c_str() to the user buffer as a final step . I think it would make a lot of sense for this layer to be a marshalling layer in and...
nguerrera created a review comment on a pull request on microsoft/cask
Yep, I literally said, I'm open to other ideas in the comment just above this. This is always my least favorite part of defining C API. My size is "correct" here because I always return "not_a_r...
nguerrera created a review comment on a pull request on microsoft/cask
Our namespace without a dot is throwing me though: CommonAnnotatedSecurityKeys. Also, I'm feeling a little rebellious on the long dll and folder names. It's hard to come back to them after four yea...