Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Add single segment tests 9bf61cb
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add single segment tests
Follow-up to https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/169#discussion_r1939210527
malberts pushed 3 commits to feat-item-label ProfessionalWiki/WikibaseFacetedSearch
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Some thoughts on the `StubValueCounter` change: * It causes unnecessary/irrelevant assertions in other tests. * Rather create a new test double, maybe `SequenceValueCounter`, that takes a `$count...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
@alistair3149 I realise the error here now (https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/172). When deselecting everything, this function will return and not update the search.
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
@alistair3149 this seems to be caused by https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/169
malberts opened an issue on ProfessionalWiki/WikibaseFacetedSearch
Fix single facet value deselect
When deselecting a single facet value, it no longer triggers a page update. https://github.com/user-attachments/assets/91d3b89d-ff43-4242-8322-3e28ab1500ae
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
js-facets-followup - Enhanced searching interface with drilldown for Wikibase
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Refactor list facet query generation logic (#169) * Refactor list facet query generation logic * Update tests 48caa0e
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Refactor list facet query generation logic
Key changes: - Move finding selected values from DOM from `getListFacetQuerySegments` to `getListFacetSelectedValues` - Rename `checkedValues` to `selectedValues` - Only pass `selectedValues` to...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
We should also have test cases for single selected value. This is going to be important for https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/166#issuecomment-2622295218.
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
If we need to comment a function, then keeping the language consistent is important. The function refers to "facet values", whereas the comment refers to "facet items".
malberts closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Generate (internal) elastic queries for haswbfacet
Follow up to * https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/38 Needs to parse the query string and might be able to use * https://github.com/ProfessionalWiki/WikibaseFacet...
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
@JeroenDeDauw No. The query generation for the search is separate from this. We still need to find a way to get the final query built by CirrusSearch and pass it into `ElasticValueCounter`.
malberts created a comment on a pull request on ProfessionalWiki/chameleon
@WouterRademaker I had a quick look at the code and this does not seem like the right approach. The `Component` base class is supposed to get a `ChameleonTemplate` injected via constructor, and ...
malberts created a comment on a pull request on ProfessionalWiki/chameleon
@WouterRademaker I did not look at the mocking. However, I had a quick look at the code and I suspect there is a much simpler solution. All components extend `Component`, which already gets an i...
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Fix imports
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/153#pullrequestreview-2585343854 and other unused imports.
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Fix imports
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/153#pullrequestreview-2585343854 and other unused imports.
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
imports - Enhanced searching interface with drilldown for Wikibase
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Build Elasticsearch queries (#153) a699d1b
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Build Elasticsearch queries
For #53 ### List facet Supported data types: * string * item * quantity * time Supported query types: * AND * OR * has any value * has no value https://github.com/user-attachment...