Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I copied it from WikibaseExport: https://github.com/ProfessionalWiki/WikibaseExport/blob/d3b9f998fff2144e9f1ffd1a48040791917267aa/tests/Application/Export/ProductionValueSetCreatorTest.php#L44-L67 ...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
> Should the return type be Terms from Elastica\Query\Terms instead of AbstractQuery? No. All the query objects extend AbstractQuery. The calling code does not need to know what kind of query is...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
> Is this partial import on purpose? It was kind of, since I this pattern being used in a few places for Elastica query objects. But I suppose this is arbitrary and WikibaseCirrusSearch imports ...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
`AbstractQuery` is the abstract class for all Elastica query objects. And the expected first parameter of the returned array. This would mainly be to test that query objects are (not) created ba...
malberts pushed 1 commit to es-query ProfessionalWiki/WikibaseFacetedSearch
- Build Elasticsearch queries 4f44dc3
malberts pushed 1 commit to es-query ProfessionalWiki/WikibaseFacetedSearch
- Build Elasticsearch queries cd9a5e5
malberts pushed 1 commit to es-query ProfessionalWiki/WikibaseFacetedSearch
- Build Elasticsearch queries 703bd50
malberts pushed 8 commits to es-query ProfessionalWiki/WikibaseFacetedSearch
- Hide facets when there are no facets Closes: #156 2ed1416
- Add .vscode to gitignore (#161) 89b2d97
- Do not render sidebar when it is empty (#160) * Do not render sidebar when it is empty Follow up to #159 * Dis... 3041f5f
- Revert "Add .vscode to gitignore (#161)" (#163) This reverts commit 89b2d97d5bd86f1d91daec402d8e9922ba7aeead. 4ef4d3e
- Add support for OR query in the Facet UI (#162) * Add support for OR query in the Facet UI #158 * Update funct... 87d6cd3
- Handle empty OR values (#167) a41a47f
- Fix incorrect label bottom margin in Chameleon The previous selector does not cover the modal 13f783f
- Build Elasticsearch queries 655ab65
malberts opened an issue on ProfessionalWiki/WikibaseFacetedSearch
Support years in list facet
When using a range facet for a date field, the generated Elasticsearch query expands the year range to include days. For example: * min `2000` becomes `2000-01-01` * max: `2010` becomes `2010-12-31...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
My first thought is that I lean slightly towards HTML language here, since this is ultimately about building a model for the frontend. And it's kind of "scoped" to a checkbox. So when I'm thinking ...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
This works, but I am wondering about the approach. We are slightly complicating the backend with a client-side concern. I imagine the backend could just provide all the checkboxes, and then JS/CSS ...
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Fix incorrect label bottom margin in Chameleon The previous selector does not cover the modal 13f783f
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Fix incorrect label bottom margin in Chameleon
The previous selector does not cover the modal
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Not handling whitespace, since that depends on quote handling (#88), otherwise the search engine will just consider it a separate token.
malberts pushed 1 commit to empty-or ProfessionalWiki/WikibaseFacetedSearch
- Handle empty OR values 44f1e00
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Handle empty OR values
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/166 * In general: removes empty values: `haswbfacet:p42=foo||bar` * Specific: allows a single OR value to be correctly parse...
malberts pushed 1 commit to empty-or ProfessionalWiki/WikibaseFacetedSearch
- Handle empty OR values 67c5a35
malberts pushed 1 commit to empty-or ProfessionalWiki/WikibaseFacetedSearch
- Handle empty OR values 25f3cd0
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
Right, that case won't be solved by the above solution. Maybe we can do this just not reload the page (just toggle it). Then when a checkbox is selected it will pick up the selected OR. This would...
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
empty-or - Enhanced searching interface with drilldown for Wikibase
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
> Would it be favorable if we use a query such as haswbfacet:P1460=P1| to notify the backend that it is in OR mode? I was just about to update the issue with that same suggestion. Yes, I think tha...