Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Use haswbfacet instead of haswbstatement for tabs
Fixes https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/151
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
js-haswbfacet - Enhanced searching interface with drilldown for Wikibase
malberts pushed 1 commit to es-query ProfessionalWiki/WikibaseFacetedSearch
- WIP ElasticQueryBuilder 23871fb
malberts opened a draft pull request on ProfessionalWiki/WikibaseFacetedSearch
WIP Build Elasticsearch queries
For #53 DO NOT REVIEW
malberts closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Use haswbfacet instead of haswbstatement for query parser
Facets are indexed on Pages, and `haswbstatement` only works on Items. Item type parsing should use `haswbfacet`. AC: * [ ] Update QueryStringParser
malberts pushed 3 commits to master ProfessionalWiki/WikibaseFacetedSearch
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Use haswbfacet for parsing item type
Fixes #150 Required by https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/53 to correctly detect the item type.
malberts pushed 1 commit to parse-type ProfessionalWiki/WikibaseFacetedSearch
- Add combined item type and values tests dba8637
malberts pushed 1 commit to parse-type ProfessionalWiki/WikibaseFacetedSearch
- Look for exact Property Id 235db8e
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
There was a logic issue here. Valid item type "P32" was going to be a substring of non-item type "P320".
malberts pushed 1 commit to parse-type ProfessionalWiki/WikibaseFacetedSearch
- Look for exact Property Id 5107972
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Use haswbfacet for parsing item type
Fixes #150
malberts pushed 25 commits to es-query ProfessionalWiki/WikibaseFacetedSearch
- Use localized label instead of entity IDs (#137) * Use localized label instead of entity IDs * Fix fallback behav... 6556eda
- Add unit tests for JS query string (#138) Closes #112 07aaf72
- Improve UiBuilder tests (#140) * Add missing argument Follow up to https://github.com/ProfessionalWiki/WikibaseFa... 933a49a
- Reformat for readability 59485c4
- Group test functions by their original function b11e2aa
- Add Jest to Makefile and document Jest command usage 11bd73b
- Use Docker for npm command 37d7729
- Fix `make test` and improve command docs 3f504d6
- Improve dev docs 5cf1553
- Stop running lint in `make jest` ef30645
- Switch to SpecialSearchResultsPrepend hook so that Facet UI is always avaliable Closes: #143 852c6e9
- Turn facets into a modal in narrow viewport d9c3d63
- Index item type cbce166
- Rename instanceOfValues to configPerItemType bcfa9fc
- Rename instanceOfId to itemTypeProperty 14064e8
- Rename itemTypeId to itemType e47e1b8
- Merge pull request #147 from ProfessionalWiki/names Rename instanceOf related symbols 38fc53b
- Add Config isComplete fc24ff8
- Move all properties into getPropertiesToIndex 68d7079
- Refactor createFields() 1c92d81
- and 5 more ...
malberts opened an issue on ProfessionalWiki/WikibaseFacetedSearch
Use haswbfacet instead of haswbstatement for tabs
Facets are indexed on Pages, and `haswbstatement` only works on Items. Item type switching in tabs should use `haswbfacet`. AC: * [ ] Update ext.wikibase.facetedsearch.js
malberts opened an issue on ProfessionalWiki/WikibaseFacetedSearch
Use haswbfacet instead of haswbstatement for query parser
Facets are indexed on Pages, and `haswbstatement` only works on Items. Item type parsing should use `haswbfacet`. AC: * [ ] Update QueryStringParser
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Extract ItemTypeLabelLookup This is preparation that adds structure and tests for https://github.com/ProfessionalWik... 0c8ebdd
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Extract ItemTypeLabelLookup
This is preparation that adds structure and tests for https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/91
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I imagine to avoid this type of test where practically it should not happen (i.e. we're not constructing the object if Config is incomplete), but technically it can, we might have to inject the kno...
malberts pushed 3 commits to index-item-type-refactor ProfessionalWiki/WikibaseFacetedSearch
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
index-item-type-refactor - Enhanced searching interface with drilldown for Wikibase
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I assume we'll do a similar refactor to change `$propertyId` to `$property` here?
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
This facet uses strings, not Items, and therefore works without a lookup:  Somewhere in here we still need ...