Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Would it be able to add a stub test for the actual JS file in the meantime? It could just load the JS and without the necessary HTML `init()` should just return. Just as an example, since it's uncl...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Is this still necessary if the paths are limited to (PHP) src and tests?
malberts pushed 8 commits to search-title ProfessionalWiki/WikibaseFacetedSearch
- Drop Codex Radio component It is not used anymore 2177c45
- Merge pull request #110 from ProfessionalWiki/followup-109 Drop Codex Radio component 5d14d40
- Allow checkbox to submit search query (#102) * Allow checkbox to submit search query * Rebuild query string from ... 72fa09a
- Drop the use of sanitizer for id attribute (#114) Mustache escape should be enough 4caf341
- Set range input type to number (#116) 9556ffc
- Act on defaultCombineWith and allowCombineWithChoice config (#111) * Act on defaultCombineWith and allowCombineWithC... 295c633
- Links TODOs to issues (#120) 642983c
- Refactor search result title rewrite 40825a6
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Links TODOs to issues (#120) 642983c
malberts pushed 3 commits to todo ProfessionalWiki/WikibaseFacetedSearch
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
> Partial UI behavior idea: Should not be combinable with values using AND (because this does not make sense: "there should be no Author and the Author should be Bob") This can be avoided by hid...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
`getRewrittenLink()`
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Act on defaultCombineWith and allowCombineWithChoice config (#111) * Act on defaultCombineWith and allowCombineWithC... 295c633
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Act on defaultCombineWith and allowCombineWithChoice config
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Should this be `WhenAndIsSelected`?
malberts created a comment on an issue on ProfessionalWiki/WikibaseFacetedSearch
Jest is fine, and is also recommended by MW. We used Vitest for other more complicated Typescript code, but here it will likely be overkill.
malberts pushed 1 commit to search-title ProfessionalWiki/WikibaseFacetedSearch
- Refactor search result title rewrite 4bc81c0
malberts pushed 1 commit to search-title ProfessionalWiki/WikibaseFacetedSearch
- Refactor search result title rewrite 5081252
malberts pushed 1 commit to search-title ProfessionalWiki/WikibaseFacetedSearch
- Refactor search result title rewrite 167a0b2
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I went with a little data class here, instead of mutating the parameters. However, this means some logic is outside of the new service. Thoughts on this versus just mutating in the method?
malberts opened a draft pull request on ProfessionalWiki/WikibaseFacetedSearch
WIP Refactor search result title rewrite
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/75 and https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/94 * Removes the old code for rewriting an Item searc...
malberts pushed 1 commit to search-title ProfessionalWiki/WikibaseFacetedSearch
- Refactor search result title rewrite deb4bd0
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
search-title - Enhanced searching interface with drilldown for Wikibase
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Add RangeFacetHtmlBuilderTest 8336509
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add RangeFacetHtmlBuilderTest
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Leftover code? Or is something not working here?