Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Support facet type specific config Config refactor not included. We do have some design issues with Config: * It is ... 7f95ae3
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Support facet type specific config
This is needed so we can access these config in ListFacetHtmlBuilder: defaultCombineWith, allowCombineWithChoice, showNoneFilter, showAnyFilter. Config refactor not included. Looks like we can ...
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Follow up to #101 (#104) * Remove unused comment * Fix indentation caused by GitHub 0160693
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
We allow open-ended ranges, so the button should not be disabled if any of the values are empty.
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
We could disable the button by default and only enable it once any value changes. But that would probably be frontend-only and would not require passing additional data to the template.
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Remove anchor element from Facet UI (#99) * Remove anchor element from Facet UI We don't need them anymore becaus... 83ce023
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Pass search query directly to createHtml ff60f8a
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Pass search query directly to createHtml
Follow up to #95
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Remove link building code and update TODO
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Remove count condition Makes the counts show up As per @malberts in https://github.com/ProfessionalWiki/WikibaseFac... 42b97c1
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Remove count condition
Makes the counts show up As per @malberts in https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/95#discussion_r1913026422  and some gain (ie real config used).
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
> For some reason the counts no longer show up, In `FacetItemLabel.mustache` we can remove the `{{#count}}` condition. ![Screenshot_20250113_130941](https://github.com/user-attachments/assets...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Since `DelegatingFacetHtmlBuilder` works on `FacetType` only, are we going to have a different `FacetType` and `FacetHtmlBuilder` for single value radio buttons? Or is that not really a use case an...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Should we use `array_map` here?
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
What flagged this as invalid HTML? It's currently `<span>` with more `<span>`s inside, which is valid. Strictly speaking, having `<div>` inside `<label>` is invalid HTML (see "Permitted content" h...