Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
query-string-quotes - Enhanced searching interface with drilldown for Wikibase
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Indeed doesn't really matter here. My feeling is to not add it, as we've done in other projects, unless there's a very explicit reason to do so (which I don't think we've ever had, hence why I noti...
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Add QueryStringParser a721b43
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Add QueryStringParser
Started with an AI-generated foundation and made many changes, both small and large I could not get the quote handling the AI put in to work correctly so skipped that for now. I also did not yet...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I assume all these `final`s were added by AI? Or are we explicitly preventing subclassing? (I'm not used to seeing this in our other code, even when classes are not really meant to be subclassed).
malberts created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
> Is there anything unique for the facet item that can be used as an ID for the <input> element? It is needed to make the label linked to the checkbox/radio. Each filter list item will have some...
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Rename Sitelink
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/51#discussion_r1901970232 Renames all instances of `[Ss]iteLink` to `[Ss]itelink` in our code, except where it is a symbol used...
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Rename Sitelink
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/51#discussion_r1901970232 Renames all instances of `[Ss]iteLink` to `[Ss]itelink` in our code, except where it is a symbol used...
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
sitelink - Enhanced searching interface with drilldown for Wikibase
malberts opened a pull request on ProfessionalWiki/WikibaseFacetedSearch
Flip condition
For https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/51#discussion_r1901912639
malberts created a branch on ProfessionalWiki/WikibaseFacetedSearch
flip-neg - Enhanced searching interface with drilldown for Wikibase
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Something to weigh up is how much of Codex we really need. We're not building a complicated UI. It is indeed nice to be futureproof with Codex, but the trade-off in this specific case is essentiall...
malberts created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
> Do you mean the two arguments to the array_map? No, the mapping and filtering are "separate" steps. In this case it's probably not a big deal to go with the functional syntax. Like I mentio...
malberts created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Sometimes it feels like the for loop reads nicer than _nested_ functional code. In the for loop getting the value and including/excluding happens in the same iteration, in sequence. Whereas with th...
malberts pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Clarify function in StatementListTranslator 6bdcf26
malberts closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Clarify function in StatementListTranslator
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Not AI generated. I suspect when I wrote the original POC there was more logic here and as I cleaned it out it ended up like this.
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
The constructor takes a string.
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I was wondering about this. We're already using both capitalizations. Maybe we should just rename all our symbols to the lowercase `Sitelink`, and then only use uppercase `SiteLink` when calling or...
malberts created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I tried using Item-specific implementations where they were available. While it is indeed technically possible to handle non-Items, my main reasons against doing that: * Property cannot have a...