Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
maiste created a comment on an issue on ocaml/dune
@Alizter thanks for the answer. Sorry, my question was ambiguous! I was wondering what is the reason behind attaching `all` to `default` including tests? I'm asking because, for example, in Golang,...
maiste pushed 1 commit to 3.17 ocaml/dune
- backport #11204: fix: regression in 11200 (#11216) Remove all error checking for empty projects in [$ dune subst] ... 324e1b5
maiste closed a pull request on ocaml/dune
[3.17] backport 11204 - remove errors message from `dune subst` with empty dir
Backport for the 3.17.1 release.
maiste created a comment on a pull request on ocaml/dune
Your backport seemed to pass the CI. I have rebased, and we will see if the error is still here. If not, I will merge this PR and prepare the release.
maiste pushed 2 commits to backport-11204 maiste/dune
- Backport #11194: `Io.copy_channels`: make it reentrant (#11218) Signed-off-by: Nicolás Ojeda Bär <[email protected]... 8835ad5
- fix: regression in 11200 (#11204) Remove all error checking for empty projects in [$ dune subst] Signed-off-by: Rud... b4f1691
maiste pushed 1 commit to 3.17 ocaml/dune
- Backport #11194: `Io.copy_channels`: make it reentrant (#11218) Signed-off-by: Nicolás Ojeda Bär <[email protected]... 8835ad5
maiste closed a pull request on ocaml/dune
[3.17] `Io.copy_channels`: make it reentrant (#11194)
Signed-off-by: Nicolás Ojeda Bär <[email protected]> (cherry picked from commit ef02bd720abf5c60242b87c7019f8ebc8635d3e1)
maiste created a comment on an issue on ocaml/dune
Thanks for reporting! Indeed, it might be interesting to add somewhere that as `test` are executable and `dune build` would build them by default as it is always present. Maybe [the default page](...
maiste opened a pull request on ocaml/dune
[3.17] backport 11204 - remove errors message from `dune subst` with empty dir
Backport for the 3.17.1 release.
maiste created a comment on an issue on ocaml/dune
Can I let you take care of the backport for this PR too? I'll backport the regression fix on my side.
maiste opened an issue on ocaml/dune
3.17.1 release tracking
## Preparation - need backport: - [ ] https://github.com/ocaml/dune/pull/11189 - [ ] https://github.com/ocaml/dune/pull/11179 - [ ] https://github.com/ocaml/dune/pull/11204#event-156526275...
maiste created a comment on an issue on ocaml/dune
For the first message, we could provide a hint. I don't know how much precise we could be when generating the `hint`. > Similarly, when there's a dependency referencing a folder without a dune f...
maiste created a comment on a pull request on ocaml/dune
I'll take care of the release `3.17.1` then :+1:
maiste created a review comment on a pull request on ocaml/dune
```suggestion | _ -> Error { Git_error.dir; args; exit_code; output = [] }) ``` Maybe I misunderstand something: why do you need `()`?
maiste created a review comment on a pull request on ocaml/dune
Is it necessary to add the type here? I don't see where it is used in the code above.
maiste created a review comment on a pull request on ocaml/dune
This file should be removed from your commits.
maiste created a comment on a pull request on ocaml-dune/binary-distribution
Feel free to ping me to review the metadata PR :+1:
maiste created a review comment on a pull request on ocaml-dune/binary-distribution
```suggestion # Prepending path in case a system-installed dune needs to be overridden ```
maiste created a review comment on a pull request on ocaml-dune/binary-distribution
```suggestion # Prepending path in case a system-installed dune needs to be overridden ```