Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
maiste created a review comment on a pull request on ocaml/dune
Because Tar is transformed to a `Path` where I need to use it, and we compute the path afterward, not in this function as we don't know where the tarball will be extracted yet.
maiste created a review comment on a pull request on ocaml/dune
I will stick with your top-level suggestion and delay zip for latter. Indeed, contrary to tar it seems to be the code to support `zip` is currently missing.
maiste pushed 1 commit to fix/pinning-10121-bis maiste/dune
- fix: typo apply suggestions from code review Co-authored-by: Marek Kubica <[email protected]> Signed-off-by: Et... 8c64e1e
maiste pushed 18 commits to staging ocaml-dune/binary-distribution
- Nightly build 2025-01-17 1da33b9
- Nightly build 2025-01-18 f568828
- Nightly build 2025-01-19 e37af87
- Nightly build 2025-01-20 37864cd
- Nightly build 2025-01-21 17ef00d
- Nightly build 2025-01-22 a84c58b
- Nightly build 2025-01-23 371a92e
- Nightly build 2025-01-24 51e5110
- Nightly build 2025-01-25 4f2116d
- Nightly build 2025-01-26 eab213b
- Nightly build 2025-01-27 79393a2
- Nightly build 2025-01-28 abb9c54
- Nightly build 2025-01-29 3287103
- Nightly build 2025-01-30 59d01b3
- Nightly build 2025-01-31 21f7f8a
- Nightly build 2025-02-01 6054dff
- Nightly build 2025-02-02 466e4e6
- Nightly build 2025-02-03 34c7052
maiste opened a pull request on ocaml/dune
fix: support package pinning via http+tar
This PR reduces the gap between opam and dune package management functionnalities. It allows users to ping a tar file (gz or bz) using `http` (and `https`) protocol. Closes #10121
maiste created a comment on an issue on ocaml/dune
Thanks for reporting. We used to have a bug that is supposed to fix on main now (so in the latest dev preview). Could you try to erase the `~/.cache/dune/toolchains` directory? I know once the bug...
maiste created a comment on a pull request on ocaml/dune
I agree! But is it a good idea to introduce it as a breaking change for `3.18` and not for `4.0`?
maiste pushed 181 commits to fix/pinning-10121 maiste/dune
- refactor(pkg): remove some dead solver code (#11228) Signed-off-by: Rudi Grinberg <[email protected]> 69bafe0
- refactor(pkg): remove [`Recommended] dep importance (#11223) it doesn't seem to be used anywhere Signed-off-by: R... 0c87030
- refactor(pkg): remove replaced-by remnants (#11233) Not used by dune (or opam) Signed-off-by: Rudi Grinberg <me@r... cd876b2
- refactor(pkg): pattern match on importance (#11236) Signed-off-by: Rudi Grinberg <[email protected]> 2017391
- refactor(pkg): inline [RoleEntry] (#11238) Signed-off-by: Rudi Grinberg <[email protected]> 0b84c87
- refactor(pkg): introduce library interface (#11240) Signed-off-by: Rudi Grinberg <[email protected]> 6dd582f
- refactor(pkg): more dead code removal (#11237) Signed-off-by: Rudi Grinberg <[email protected]> 00e1bcc
- refactor(pkg): more simplifications (#11241) in the style of dune Signed-off-by: Rudi Grinberg <[email protected]> 0a43607
- feat(dune): support `+` prefixes for PPX CLI flags (#11234) * test(ppx): show flags starting with `+` are interpre... 30af715
- chore: add changelog for #11234 (#11242) Signed-off-by: Antonio Nuno Monteiro <[email protected]> c973f16
- fix(haiku): execve not allowed if other pthreads have already been created (#10953) * fix(haiku): execve not allowed... acb928f
- refactor(pkg): move cache to separate module (#11244) Signed-off-by: Rudi Grinberg <[email protected]> b59480c
- refactor(pkg): make cache polymorphic (#11245) Signed-off-by: Rudi Grinberg <[email protected]> 975bfec
- refactor(pkg): remove candidates class (#11239) Signed-off-by: Rudi Grinberg <[email protected]> 3e93d6a
- refactor(pkg): use [Stdune] more (#11249) Signed-off-by: Rudi Grinberg <[email protected]> 4f15a12
- test(melange): virtual library compilation with private libs (#11246) Signed-off-by: Antonio Nuno Monteiro <anmontei... 4757aa6
- fix(melange): use output of virtual library when compiling its source (#11248) * test(melange): show crash when dep... f0137df
- test(melange): show compilation error for Melange public virtual lib (#11247) * test(melange): show compilation erro... 9020dc9
- refactor(pkg): inline [Model] (#11251) Signed-off-by: Rudi Grinberg <[email protected]> 34de4d1
- refactor(pkg): simplifications of new candidates module (#11250) Signed-off-by: Rudi Grinberg <[email protected]> 3b9d0fd
- and 161 more ...
maiste opened a pull request on ocaml/dune
feat: introduce env_vars alias for env-vars
This PR introduces an alias `env_vars`, for `env-vars`, to keep the configuration uniformity (using the underscore instead of dash). Closes #11424
maiste created a review comment on a pull request on ocaml/dune
You are right, maybe it is because I'm more used to matching on variables instead of expression.
maiste created a comment on an issue on ocaml/dune
```lisp (ctypes ;; [...] (deps (:h ocaml_bindings.h)) ;; [...] ``` It might be a dummy suggestion, but can you try without the quotes? Because, looking at the code, the decoder is suppos...
maiste created a review comment on a pull request on ocaml/dune
Indeed, sorry, I wrote my replies without reloading the page. Thanks! :+1:
maiste created a review comment on a pull request on ocaml/dune
```suggestion Package_name.of_opam_package_name pkg |> Package_name.Map.find t.constraints name ``` Considering this PR is adding |>, is there a reason not to do this?
maiste created a review comment on a pull request on ocaml/dune
Wouldn't it be more readable if env was computed outside the `match ... with`?
maiste created a review comment on a pull request on ocaml/dune
```suggestion OpamPackage.name package |> Package_name.of_opam_package_name |> Package_name.Map.mem t.local_packages ``` Considering this PR is adding `|>`, is there a reaso...
maiste pushed 1 commit to main ocaml/dune
- docs: bug_report.md add missing colon (#11441) Signed-off-by: Louis <[email protected]> 26d680d
maiste closed a pull request on ocaml/dune
bug_report.md: add missing :
Very minor, but every time I open an issue I see it missing and it finally bothered me enough to submit this PR.