Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
maiste created a review on a pull request on ocaml-dune/binary-distribution
Small typos but LGTM :+1: As we change the installation, my recommendation would be to try on the `staging` branch to make sure it work as expected: ``` git switch staging git reset --hard dot...
maiste created a review on a pull request on ocaml-dune/binary-distribution
Small typos but LGTM :+1: As we change the installation, my recommendation would be to try on the `staging` branch to make sure it work as expected: ``` git switch staging git reset --hard dot...
maiste created a review comment on a pull request on ocaml-dune/binary-distribution
Why not use `remove_home` here?
maiste created a review comment on a pull request on ocaml/dune
art: ```suggestion This must **be specified.** ```
maiste created a review comment on a pull request on ocaml/dune
I would also point the `(repositories ...)` stanza here to clarify which one we are talking about.
maiste created a review comment on a pull request on ocaml/dune
art: ```suggestion This must **be specified**. ```
maiste created a review comment on a pull request on ocaml/dune
```suggestion This must **be specified**. ``` :art: Same question as the other part of the documentation.
maiste created a review comment on a pull request on ocaml/dune
art: Same as the others: link and explicit about the context?
maiste created a review comment on a pull request on ocaml/dune
Shouldn't it be more explicit that it needs to be in `(pins ...)` (IIUC)?
maiste created a review comment on a pull request on ocaml/dune
art: I would suggest the same as the other two: link to package management and a description that this is related to package management apart from within the warning. Again, feel free to ignore ...
maiste created a review comment on a pull request on ocaml/dune
Shouldn't this file specified `required` / `be specified` fields?
maiste created a review comment on a pull request on ocaml/dune
```suggestion This stanza configures settings for lock directories who are relevant to ``` Otherwise, I'm not sure to get the meaning of the sentence :sweat: Shouldn't we mention that this i...
maiste created a review comment on a pull request on ocaml/dune
Do we have a convention for `required` vs `optional` in the documentation? If not, I think we should think about some uniformity (not for this PR but keep it in a corner of our head). :art: I w...
maiste created a review comment on a pull request on ocaml/dune
art: I would add a pointer to the explanation about package management you wrote. But this is just my trying to create a graph in the documentation :smile:
maiste created a review on a pull request on ocaml/dune
Many remarks are some duplicates in case you want to change them across the documentation. I have used the :art: to mentioned "cosmetic" changes and in case you want to ignore them.
maiste created a review on a pull request on ocaml/dune
Many remarks are some duplicates in case you want to change them across the documentation. I have used the :art: to mentioned "cosmetic" changes and in case you want to ignore them.
maiste created a comment on an issue on ocaml/dune
Everything is merged so I'm closing the issue.
maiste closed an issue on ocaml/dune
3.17.0 release tracking
## pre-branch blockers (none) ## known blockers - [x] All 3.17 changelogs merged #11144 - [x] test mirage ([GitHub Worfkow](https://github.com/ocaml/dune/actions/runs/11957948268)) - [x]...maiste pushed 2 commits to main maiste/maiste.fr
maiste pushed 2 commits to main maiste/maiste.fr
maiste pushed 2 commits to main maiste/maiste.fr
maiste pushed 1 commit to main maiste/maiste.fr
- feat(about): improve the content of about.md b674125