Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

layershifter

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui
`opacity` might not be the right choice for this scenario as an item remains clickable & keeps its cursor: ![2025-02-03 10 40 24](https://github.com/user-attachments/assets/21bdd300-d156-4ec6-b2...

View on GitHub

layershifter created a review comment on a pull request on microsoft/fluentui
IMO this should be moved to state as in other components

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a review comment on a pull request on microsoft/fluentui
```suggestion it('should disable selection cell input if the row is in a header and the selection mode is single', () => { ``` 🐱

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a comment on an issue on microsoft/fluentui
keep open

View on GitHub

layershifter created a review comment on a pull request on microsoft/fluentui
@mltejera great start, I fixed wording in some areas and mostly focused on improving code snippets and formatting. Here is my result, feel to grab it: ```` Theming is a really important part of...

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a review comment on a pull request on facebook/stylex
https://github.com/microsoft/griffel/blob/84fabade37aa190f0e80d2914f59e6db0ab936f7/packages/core/src/runtime/utils/hashPropertyKey.ts#L33C1-L38C4 This trick will help to avoid quotes if you want...

View on GitHub

layershifter created a review on a pull request on facebook/stylex

View on GitHub

layershifter created a comment on an issue on microsoft/fluentui
<img width="372" alt="Image" src="https://github.com/user-attachments/assets/832f306f-0733-490a-9451-49550cdd516c" /> https://react.fluentui.dev/?path=/docs/components-menu-menu--docs#multiline-items

View on GitHub

layershifter deleted a branch layershifter/office-ui-fabric-react

feat/positioning-react

layershifter pushed 1 commit to master microsoft/fluentui
  • feat(react-positioning): allow to configure boundaries with "PositioningRect" (#33724) 808cd50

View on GitHub

layershifter closed a pull request on microsoft/fluentui
feat(react-positioning): allow to configure boundaries with "PositioningRect"
## New Behavior Floating UI supports defining boundaries as `Rect`s (https://floating-ui.com/docs/detectOverflow#boundary), this PR allows it via types. - Exposes `PositioningBoundary` & `Po...
layershifter created a review comment on a pull request on microsoft/fluentui
Added [f5fffa9](https://github.com/microsoft/fluentui/pull/33724/commits/f5fffa93191ac21f38a49d5bc80fe084bfdefb27)

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a comment on an issue on microsoft/fluentui
keep open

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter pushed 1 commit to feat/positioning-react layershifter/office-ui-fabric-react

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a review comment on a pull request on microsoft/fluentui
```suggestion const [handle] = React.useState(() => { let isMultiline = false; let multilineNode: HTMLElement | null = null; function applyAttr() { multilineNode?.toggleA...

View on GitHub

layershifter created a review comment on a pull request on microsoft/fluentui
```suggestion node.setAttribute(menuSplitGroupMultilineAttr, ''); ```

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a review comment on a pull request on microsoft/fluentui
Looks like a `useState()` based approach would work there nicer: ```ts const [[multilineRef, setMultiline]] = useState(() => { let isMultiline = false; let multilineNode: HTMLElement | nu...

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a review comment on a pull request on microsoft/fluentui
[toggleAttribute](https://developer.mozilla.org/en-US/docs/Web/API/Element/toggleAttribute) ?

View on GitHub

layershifter created a review on a pull request on microsoft/fluentui

View on GitHub

layershifter created a review comment on a pull request on microsoft/fluentui
nit: ```suggestion const useNotifySplitItemMultiline = (options: { hasSubmenu: boolean; isMultiline: boolean }) => { ``` as you don't need the slot itself

View on GitHub

Load more