Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
If you feel it is worth the investment, we might be able to find a way to convert it into a JSON object and make assertions on it. I've already added test setup code to convert a JSON object into a...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Unfortunately, this transactionRequest object is not a dict, it is a type unique to the Authorize.net SDK, which is incredibly nasty to work with since under the hood it is converting this object t...
landonshumway-ia created a comment on a pull request on csg-org/CompactConnect
@isabeleliassen the conversation has now been resolved. Thanks
landonshumway-ia created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This should be ready for your review.
landonshumway-ia created a review on a pull request on csg-org/CompactConnect
Great, this looks much better with the CCPermissionsAction enum
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
any reason to leave this in a commented out state, rather than just removing them completely?
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Honestly, it would be good to have an enum for all of these permission actions now that the list keeps growing. But I won't hold up the PR if you just want to stick with all the hardcoded values fo...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I feel like this is a case where we should explicitly list the API calls this lambda is allowed to make, rather than using the 'grant_read_data' method, which of course grants more than is needed. ...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
ditto on using an enum for the 'readSSN' permission, makes it much easier to track where we are using the permission
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Can we mark this as a TODO, so that it's harder to miss?
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
nit - It would be nice if we could move 'readSSN' into an enum, rather than hardcoding it here.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
We'll have to figure out how this works in the case where a provider's SSN was mistyped on a license and then later adjusted, but I would imagine we would just be making an in place update on the e...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Can we add a comment here that the 392 is associated with the ticket number? It took me some time to draw the connection.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Great test to check for 👍
landonshumway-ia pushed 1 commit to feat/require-attestations InspiringApps/JCC-CompactConnect
- update docstring to use reST format fe2b514
landonshumway-ia pushed 1 commit to feat/require-attestations InspiringApps/JCC-CompactConnect
- Adding migration script for existing data to include attestations 995b55a
landonshumway-ia pushed 7 commits to feat/require-attestations InspiringApps/JCC-CompactConnect
- Feat/pi confirmation (#515) ### Requirements List - A licensee user who's schema is up to date and who has been thr... a1033dd
- Feat/reinvite staff user (#495) ### Description List - Added a `POST staff-user/:userId/reinvite` endpoint that wil... 48959e1
- frontend/registration UI (#498) ### Requirements List - New local `.env` variable: - `VUE_APP_RECAPTCHA_KEY` ... 390d308
- Feat/privilege numbers (#510) ### Description List - Assign a new privilege id on privilege purchase - Reuse privi... 50ee223
- Feat/monthly reports (#508) CSG has requested that we implement automated monthly transaction reporting. This requi... 5556649
- Make attestations field required when purchasing privileges Now that the frontend has been updated to pass in attest... cfbba8b
- remove unused import 9ca0b27
landonshumway-ia pushed 1 commit to development InspiringApps/JCC-CompactConnect
- Feat/monthly reports (#508) CSG has requested that we implement automated monthly transaction reporting. This requi... 5556649
landonshumway-ia pushed 1 commit to feat/transaction-fee-config InspiringApps/JCC-CompactConnect
- Remove reference to processorFee config from onboarding 8a5d247
landonshumway-ia created a comment on a pull request on csg-org/CompactConnect
@isabeleliassen those have now been resolved. This should be ready to go. Thanks.
landonshumway-ia pushed 1 commit to feat/monthly-reports InspiringApps/JCC-CompactConnect
- PR Feedback - setting to first day of month dcb20cb
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Sure, that makes sense. I'll make that update.
landonshumway-ia pushed 1 commit to feat/transaction-fee-config InspiringApps/JCC-CompactConnect
- Add smoke tests for licensee transaction fee check 3e8320c
landonshumway-ia pushed 3 commits to feat/transaction-fee-config InspiringApps/JCC-CompactConnect
landonshumway-ia pushed 1 commit to feat/transaction-fee-config InspiringApps/JCC-CompactConnect
- add transaction fee fields to API schema 4c98ab3