Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
landonshumway-ia pushed 1 commit to feat/licensee-registration InspiringApps/JCC-CompactConnect
- PR feedback part 2 - simplify test logic - using filter expression to find matching license 56baf1d
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Great call, that significantly simplifies things
landonshumway-ia pushed 2 commits to feat/licensee-registration InspiringApps/JCC-CompactConnect
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
ah good point, I'll ask @jsandoval81 on this one
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I've removed the catch block
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Good point, I agree we don't need the extra catch block. I've updated it to raise a not found exception in the event that it has not been set.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
This was the only way I could get it to work 🤷 I spent a solid 15 minutes on it and the property was just not being mocked as expected so I ran with what worked.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I don't want to log too much PII, but still have context to triage. I'd be curious of your thoughts on this though.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I would say if it ends up getting used in more than one place, then we can extract it into a class, but given the time constraints I didn't think it was worth the investment upfront.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
ah good catch, that should be 3, I was jumping back and forth between the value to set and forgot to update this comment.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
This was for backwards compatibility with our current data that does not have these fields, my understanding is because they are required we need to populate them before loading the data else there...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
That is done through an Staff user API endpoint to upload their authorize.net credentials `/v1/compacts/{compact}/credentials/payment-processor` which is not a manual process, hence it is not docum...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
see previous comments about request schema
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
The public facing API does not map one to one with the internal schema by design. This is the POST request schema that @jsandoval81 and I approved previously. If we feel strongly that any of these ...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
We are explicitly not mapping the internal schema fields to the public facing API, to prevent crawlers from identifying the use of ssn in the form