Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
landonshumway-ia pushed 1 commit to feat/weekly-reports InspiringApps/JCC-CompactConnect
- Formatting/linting 1b3e37e
landonshumway-ia opened a draft pull request on csg-org/CompactConnect
Feat/weekly reports
compact commission admins and state admins will want to know how many compact privileges were purchased in a week, who purchased them, which states they were purchased for, and the cost totals so t...
landonshumway-ia pushed 1 commit to feat/weekly-reports InspiringApps/JCC-CompactConnect
- Handle case where unknown jurisdiction is found in transactions This is very unlikely to occur in the system, but if... b213565
landonshumway-ia created a branch on InspiringApps/JCC-CompactConnect
feat/weekly-reports - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
landonshumway-ia created a comment on a pull request on csg-org/CompactConnect
This is ready for your review @jlkravitz
landonshumway-ia pushed 2 commits to development InspiringApps/JCC-CompactConnect
landonshumway-ia pushed 1 commit to feat/attestation-tracking InspiringApps/JCC-CompactConnect
- Add comment regarding version stored as string 85bb35a
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I've updated the comment to hopefully make it more clear
landonshumway-ia pushed 1 commit to feat/attestation-tracking InspiringApps/JCC-CompactConnect
- PR feedback 73c6d69
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
We can... it just makes the serialization/deserialization a little more tricky to mess with. DynamoDB stores all numbers as a 'Decimal' type regardless if it is an integer or float, which will caus...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Good call out, initially I had it as an optional field, but there's no reason it shouldn't be required. All of our current configuration files have it included, so I will remove this check and we'l...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
same here: `_populate_update_record`
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
nit: should start with underscore if we don't intend to call it outside of this file: `_process_license_update`
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Just need to check my understanding here: with the way this is structured, it suggests that the base license and privilege records will ALWAYS come first in the array before any update records for ...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
This right here makes me wonder if we should consider choosing other separators if we need to have logic like this... Are there not other options we could use that wouldn't require this?
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
This is a pretty critical piece, as whatever pattern we choose we will essentially be locked into forever to determine the update records by hash. I am trying to walk through any drawbacks with thi...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
We should also have a log statement showing that we are restoring the record and what the change would have been. Given that we don't expect this code to get exercised very often, we should be fine...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
missing a error log message here that would be useful for context
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
it may be helpful to have a log message here noting that we are deleting something, so we at least have some paper trail of what record would have shown up in the system
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
We should leave a comment here explicitly calling out why we append the provider privilegeJurisdictions update last, so no one ever moves it to an earlier step in the algorithm.
landonshumway-ia pushed 3 commits to development InspiringApps/JCC-CompactConnect
- path-to-regexp dependency update (#432) ### Requirements List - `yarn install --ignore-engines` ### Description ... f32cad7
- Frontend/Fix pw input validation messages (#430) ### Requirements List - _None_ ### Description List - Move mes... 20f3115
- Frontend/permission api updates (#428) ### Requirements List - _None_ ### Description List - Change compact-lev... 235c8ce
landonshumway-ia pushed 2 commits to feat/attestation-tracking InspiringApps/JCC-CompactConnect
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Yes, essentially the UI will be well aware of each attestation id value and these id values, as the attestations we are displaying on their respective pages are part of the design. Because of this,...