Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

landonshumway-ia

landonshumway-ia created a comment on a pull request on csg-org/CompactConnect
I've confirmed the local deployment work for my sandbox. @jlkravitz This is ready for CSG review. Thanks

View on GitHub

landonshumway-ia created a branch on InspiringApps/JCC-CompactConnect

feat/state-not-uploading-notification - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.

landonshumway-ia created a review on a pull request on csg-org/CompactConnect
LGTM 👍

View on GitHub

landonshumway-ia pushed 1 commit to feat/data-validation-emails-rebased InspiringApps/JCC-CompactConnect
  • Remove duplicate lines added by rebase ad15d1b

View on GitHub

landonshumway-ia pushed 26 commits to feat/data-validation-emails-rebased InspiringApps/JCC-CompactConnect
  • Feat/Record licensee id in privilege transactions (#368) For reporting purposes, we must capture the user id of the ... 8db8412
  • Feat/standardize timezone used to track datetimes (#369) Previously, our system was using a non-standard timezone fo... f1ceb08
  • Add QueuedLambdaProcessor, DataEventsTable constructs 078e731
  • Standardize license event format 3bbb2ca
  • Add data event processing infra, tests 8f0112d
  • WIP: start sketching out data validation emailer ae796b0
  • WIP: emailer imp 1 60a2252
  • Get EmailBuilderJS working cb6f78e
  • Get jurisdictions from JurisdictionClient 479b481
  • Move lambdas to node/python folders f2fff68
  • Send myself an ingest report email with real errors 43fd2c0
  • Test check-lambda-js action 10c94a9
  • Make dependency audits concistent across lambdas c574a89
  • Add alls well email, npm to yarn 226b905
  • Refine email content 6917d3c
  • Drop testing action trigger bda966a
  • Allow only running python tests in script e01aac5
  • Correct event payload model dc2199f
  • Address PR comments f52929f
  • Revert to UTC timezone Related to [#356][0], we are using the standard UTC timezone for any records. We will only us... 013776e
  • and 6 more ...

View on GitHub

landonshumway-ia created a comment on an issue on csg-org/CompactConnect
Dependent on #199 being merged in so we can leverage email library

View on GitHub

landonshumway-ia created a comment on a pull request on csg-org/CompactConnect
@jusdino I attempted to pull this down and deploy it locally to my Sandbox account, and noticed that the build failed until I performed the following two steps: 1. install esbuild globally by ru...

View on GitHub

landonshumway-ia created a comment on a pull request on csg-org/CompactConnect
@jusdino if everything looks good here, we can either send this PR to Josh for review or move these changes into your current branch.

View on GitHub

landonshumway-ia opened a draft pull request on csg-org/CompactConnect
Feat/data validation emails rebased
This PR is #349 rebased with the development branch to resolve some egregious merge conflicts. Keeping it on this separate branch to review with @jusdino. ### Requirements List - ### Descrip...
landonshumway-ia created a branch on InspiringApps/JCC-CompactConnect

feat/data-validation-emails-rebased - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.

landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I agree the field name discrepancies should be fixed, but I don't believe that is a concern of this ticket, since this change is already not trivial and shouldn't mix two major schema changes in on...

View on GitHub

landonshumway-ia created a review on a pull request on csg-org/CompactConnect

View on GitHub

landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Same reason, it's backwards incompatible to change it and would break the current system. @jusdino is planning on updating the compact config file schema in the `backend/compact-connect/compact-con...

View on GitHub

landonshumway-ia created a review on a pull request on csg-org/CompactConnect

View on GitHub

landonshumway-ia opened an issue on csg-org/CompactConnect
Add automated smoke/integration tests into CDK pipeline
To save on overall development time and improve robustness of our systems, this project would greatly benefit from adding a suite of automated smoke/integration tests. We currently have a couple of...
landonshumway-ia pushed 1 commit to feat/standard-timezone InspiringApps/JCC-CompactConnect
  • PR feedback - remove super method calls afebc24

View on GitHub

landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
see comment above

View on GitHub

landonshumway-ia created a review on a pull request on csg-org/CompactConnect

View on GitHub

landonshumway-ia pushed 1 commit to feat/standard-timezone InspiringApps/JCC-CompactConnect
  • Update datetime check to always validate string d4e82a6

View on GitHub

landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
The alternative to this is to check if the hour, minute, and seconds of the converted datetime are all 0... but the problem with that is the edge case where a record happened to be created exactly ...

View on GitHub

landonshumway-ia created a review on a pull request on csg-org/CompactConnect

View on GitHub

landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Honestly yeah, but that would be a backwards incompatible change with what we currently have in the system. If we were to change it we would need to modify quite a few places in the code.

View on GitHub

landonshumway-ia created a review on a pull request on csg-org/CompactConnect

View on GitHub

landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Yeah, it took me way too long to figure out how to mock the `current_standard_datetime` property 😆 but it makes it super nice for controlling timestamps.

View on GitHub

landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Yes. now that we have a consistent pattern for mocking the datetime value, I am able to control what the SK values are for both the expected and actual records, so I don't need to pop them from the...

View on GitHub

landonshumway-ia created a review on a pull request on csg-org/CompactConnect

View on GitHub

landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
So the reason I added the super call was because it was not working without it. Although reading through your link I'm realizing it probably wasn't working because I was using the same method name,...

View on GitHub

landonshumway-ia created a review on a pull request on csg-org/CompactConnect

View on GitHub

landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I tried this, but unfortunately the check `dt = datetime.fromisoformat(value)` passes regardless if it is just a Date or a DateTime. If it's a date it create a datetime with the hours, minutes, sec...

View on GitHub

landonshumway-ia created a review on a pull request on csg-org/CompactConnect

View on GitHub

Load more