Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jsandoval81 opened a pull request on csg-org/CompactConnect
Frontend/hifi style
### Requirements List - _None_ ### Description List - Swapped out the existing lo-fi app style for the hi-fi design version - https://www.figma.com/design/SYM0uWszsu8Sf0YfxAhIMY/JCC?node-...
jsandoval81 pushed 1 commit to frontend/hifi-style InspiringApps/JCC-CompactConnect
- Minor updates 25a3ec0
jsandoval81 pushed 5 commits to frontend/hifi-style InspiringApps/JCC-CompactConnect
- Test and fix empty action handling (#413) ### Requirements List - Bug fix for #412 ### Description List - Revi... ab920aa
- Frontend/vue i18n update (#380) bbbc3e1
- Frontend/Fix search paging case (#384) dd33c78
- Merge branch 'development' into frontend/hifi-style efd14a1
- Update green base color to be wcag aa against white 4e30707
jsandoval81 pushed 3 commits to development InspiringApps/JCC-CompactConnect
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
@jlkravitz For more context, we don't have a full mock replacement of sessionStorage / localStorage in our test runner at the moment. We only have a very small number of difficult-to-test cases for...
jsandoval81 pushed 1 commit to frontend/hifi-style InspiringApps/JCC-CompactConnect
- Implementing hifi styles - Add styling to the purchase workflow - @todo: Smoke testing & test coverage 3d85bf8
jsandoval81 pushed 1 commit to frontend/hifi-style InspiringApps/JCC-CompactConnect
- WIP: Implementing hifi styles - Licensee nav manu items added - Licensee dashboard styles updated - Started styling p... bad972d
jsandoval81 created a comment on an issue on csg-org/CompactConnect
@jlkravitz This one is addressed in #383 (currently in CSG review).
jsandoval81 created a comment on an issue on csg-org/CompactConnect
Consider adding a top level route at `/Privileges`. This has a few advantages: - Gives the main app nav router-link a parent path so the nav item can stay highlighted throughout the workflow - Act...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Gotcha. I can't actually edit #325. Do you mind adding the following to the original ticket notes: - Update API docs to reflect that the top-level `actions` prop can only conditionally be includ...
jsandoval81 created a comment on an issue on csg-org/CompactConnect
Notes to self: - This is a regression introduced **after** initial Account page PR, which was merged on 2024-11-12 - Likely introduced in Sprint 12 hotfix PR merged on 2024-11-22
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Ah, I think then **1)** the API docs need to be updated, and / or **2)** the backend could be updated to be idempotent, and / or **3)** the frontend can conditionally exclude request props. Let ...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Yep, I see now. That will be overhauled in the in-progress #313.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
I created #408 cc @isabeleliassen
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
I see. I think I misunderstood. I thought you were saying you couldn't tab through the nav items. But it sounds like the entire nav menu isn't togglable on mobile w/ keyboard, correct? If that's...
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
Frontend changes look good. Great job 🚀
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Do you mind creating a ticket for this one? It might also be good to have the repro steps (unless it basically happens in all cases).
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Do you mind creating a ticket for this one?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
@jlkravitz Do you mind creating a ticket for this? Speaking w/ @isabeleliassen & @StacyNGriffin this week it sounds like we'll want to have the option to work these at a lower priority than current...