Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 opened a pull request on csg-org/CompactConnect
Add aria-label to mobile nav logo
### Requirements List - _None_ ### Description List - Add aria-label to mobile nav logo ### Testing List - `yarn test:unit:all` should run without errors or warnings - `yarn serve` should...
jsandoval81 created a branch on InspiringApps/JCC-CompactConnect
frontend/mobile-nav-aria-label - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
@jlkravitz The string matching part of a plugin was not behaving as expected. Given this isn't enforced on the server anyway, we can just remove that validation for now. PR #483 opened for your rev...
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This hotfix is ready for your review.
jsandoval81 opened a pull request on csg-org/CompactConnect
Simplify password constraints to match server
### Requirements List - _None_ ### Description List - Joi password plugin was not string matching all cases as expected, so we just removed that constraint since it wasn't server enforced anyw...
jsandoval81 created a branch on InspiringApps/JCC-CompactConnect
frontend/remove-pw-constraint - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
jsandoval81 opened a draft pull request on csg-org/CompactConnect
WIP: Attestations page
### Requirements List - _None_ ### Description List - TODO ### Testing List - `yarn test:unit:all` should run without errors or warnings - `yarn serve` should run without errors or warnin...
jsandoval81 created a branch on InspiringApps/JCC-CompactConnect
frontend/attestation-page - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Another option is to just control loading UI from the page component itself. Even if it's not a custom spinner component like the Lists have, you could just have these licensee detail pages just re...
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Looks really good. Tests well across browsers incl. the mobile simulator. 🚀 Just a few follow-on questions below about 2 items before the renewal updates.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Does moving from casting to type declaration make any difference? E.g.: ``` this.licenseePrivileges.forEach((privilege: License) => { ... privilege.history?.forEach((historyItem: Lice...
jsandoval81 created a comment on an issue on csg-org/CompactConnect
@isabeleliassen We can remove this in favor of #264
jsandoval81 pushed 1 commit to frontend/registration-ui InspiringApps/JCC-CompactConnect
- WIP: Registration UI b5248d4
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Just for my reference, how is `isLoadingOne` used differently than `isLoading` throughout the app?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same question as previous.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Is this something that will expand later? Or can it just be a string literal at the call site?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
This is interesting. Was Vue complaining without the static prefix here?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
The computed is `affiliationType` but the inner return is `militaryStatus`. Is that intentional?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same as previous comment about `alt` text. Seems fine to use the same ~"License section" text as before for all the cases on this page.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Negative margins are really dicey. They generally come back to bite when making updates. Is there an alternative here?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
If there's not a city, this looks like it will include the comma & space anyway. Is there a quick conditional we can perform to keep it cleaner? Maybe we also don't have to t deeply traverse `this....
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Does the outer computed name maybe make more sense as `militaryStatus` and the inner function body can use `status`?