Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Does the outer computed name maybe make more sense as `militaryStatus` and the inner function body can use `status`?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same as previous comment.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
We can probably type these 2 props in more detail. They probably don't need separate models yet. Just something like: ``` previousValues?: { compactTransactionId?: string | null, date...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same as previous comment.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
This casting can probably go away if the updates to the model noted above are made. You may also be able to eliminate the `if` block by using `privilege.history?.forEach(` - or maybe with the updat...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
`alt` text should ideally be translated. Looks like the language files would just need 1 new entry for ~"Privilege section".
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
This doesn't seem super necessary for this PR. I'm curious if this is something your editor yells about or does automatically?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Let's also add this prop to the `InterfaceLicense` as `Array <LicenseHistoryItem>`. Here we can instantiate the default as `[]`. Avoiding null for array types is generally easier to work with - jus...
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Looking solid 👍 Nice clear naming of things.
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Looking solid 👍 Nice clear naming of things.
jsandoval81 pushed 1 commit to frontend/registration-ui InspiringApps/JCC-CompactConnect
- WIP: Registration UI 10f9469
jsandoval81 created a branch on InspiringApps/JCC-CompactConnect
frontend/registration-ui - A system to share professional licensure data between state licensing boards for participating in occupational licensure compacts.
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Yep. I think some updates to the swagger docs are coming soon. They got a little decoupled from the original code updates but are on their way. I think they'll also be accompanied by some testing /...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
We generally try to avoid early returns. Also the default of `return { name: '' || null, date: '' };` it looks like `name` will always fallback to `null`. Overall is there a way to clean up the bod...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
As it stands, the "required" message is kind of awkward: <img width="722" alt="Screenshot 2025-01-10 at 9 23 11 AM" src="https://github.com/user-attachments/assets/38e93f95-edc4-449c-a49a-ff4bc770...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
It looks like we'll need to implement focus trapping to fully support keyboard nav. There's a recent example of this in the `SelectedStatePurchaseInformation` component. It's just a single method t...
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Functionality looks solid. Just a few trailing items that are pretty minor.
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Functionality looks solid. Just a few trailing items that are pretty minor.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
The board ED user situation is handled up near line ~365; to not have board EDs attempt to send those props at all, even if false. This section here is related to some testing & conversations we...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
The tests are just for the generic functionality of the low-level InputPassword component, so we know we can use them later if needed. You're correct that the app implementation in this ChangePa...
jsandoval81 created a comment on an issue on csg-org/CompactConnect
Per the latest standup, we'll also remove specific character requirements for now in order to align with the latest NIST recommendation.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
If the API supported paging, these would at least trigger a re-fetch of the data. Does it make sense to have them just do that for now? If not, you could just have them `return false` & add comment...
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 pushed 1 commit to frontend/pw-input-fix InspiringApps/JCC-CompactConnect
- Simplify client-side pw validation for v1 395f4a2